sdgathman
provided feedback
on gyp-0.1-0.33.fcd686f1git.el8.1
a month ago
Successfully used to build cjdns for EPEL8.
Works
no problems spotted
Seems fine.
LGTM
pwalter
kuosmanen
frantisekz
atim
samoht0
davdunc
bojan
vvvelichkov
$ fc-validate -l th /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:0 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:1 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:2 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:3 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:4 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:5 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:6 Missing 74 glyph(s) to satisfy the coverage for th language
/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:7 Missing 74 glyph(s) to satisfy the coverage for th language
$ echo $?
1
$ fc-validate -l zh_cn /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:0 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:1 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:2 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:3 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:4 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:5 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:6 Satisfy the coverage for zh-cn language /usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc:7 Satisfy the coverage for zh-cn language $ echo $?
LGTM, thanks.
Works
Works
Works for me. No regressions noted compared to previous version.
Works for me. No regressions noted compared to previous version.
Works for me. No regressions noted compared to previous version.
lgtm
jridky
chr77
hhlp