Comments

996 Comments

Indeed, openQA tests passed this time.

karma

This update should NEVER BE PUSHED, it breaks dependencies if pushed alone and a newer dnf build is in this multi-package update.

yep, openQA runs into the same problem:

 Problem: package python3-requests-2.21.0-2.fc30.noarch requires python3.7dist(urllib3) < 1.25, but none of the providers can be installed
  - cannot install both python3-urllib3-1.25.7-1.fc30.noarch and python3-urllib3-1.24.3-2.fc30.noarch
  - cannot install both python3-urllib3-1.24.3-2.fc30.noarch and python3-urllib3-1.25.7-1.fc30.noarch
  - cannot install both python3-urllib3-1.24.1-3.fc30.noarch and python3-urllib3-1.25.7-1.fc30.noarch
  - cannot install the best update candidate for package python3-urllib3-1.24.3-2.fc30.noarch
  - cannot install the best update candidate for package python3-requests-2.21.0-2.fc30.noarch
karma

This breaks anaconda - an installer image built with this DNF fails to successfully complete an install, with this traceback:

08:02:48,050 CRT exception: Traceback (most recent call last):

  File "/usr/lib64/python3.7/site-packages/pyanaconda/threading.py", line 280, in run
    threading.Thread.run(self)

  File "/usr/lib64/python3.7/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation.py", line 394, in run_installation
    queue.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 484, in start
    self.run_task()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 450, in run_task
    self._task(*self._task_args, **self._task_kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/payload/dnfpayload.py", line 1404, in post_install
    self._base.close()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 466, in close
    self._finalize_base()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 445, in _finalize_base
    "'%s'."), "{prog} clean packages").format(prog=dnf.util.MAIN_PROG)

AttributeError: 'NoneType' object has no attribute 'format'
karma

This breaks anaconda - an installer image built with this DNF fails to successfully complete an install, with this traceback:

08:02:48,050 CRT exception: Traceback (most recent call last):

  File "/usr/lib64/python3.7/site-packages/pyanaconda/threading.py", line 280, in run
    threading.Thread.run(self)

  File "/usr/lib64/python3.7/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation.py", line 394, in run_installation
    queue.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 484, in start
    self.run_task()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 450, in run_task
    self._task(*self._task_args, **self._task_kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/payload/dnfpayload.py", line 1404, in post_install
    self._base.close()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 466, in close
    self._finalize_base()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 445, in _finalize_base
    "'%s'."), "{prog} clean packages").format(prog=dnf.util.MAIN_PROG)

AttributeError: 'NoneType' object has no attribute 'format'
karma

This breaks anaconda - an installer image built with this DNF fails to successfully complete an install, with this traceback:

08:02:48,050 CRT exception: Traceback (most recent call last):

  File "/usr/lib64/python3.7/site-packages/pyanaconda/threading.py", line 280, in run
    threading.Thread.run(self)

  File "/usr/lib64/python3.7/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation.py", line 394, in run_installation
    queue.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 484, in start
    self.run_task()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 450, in run_task
    self._task(*self._task_args, **self._task_kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/payload/dnfpayload.py", line 1404, in post_install
    self._base.close()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 466, in close
    self._finalize_base()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 445, in _finalize_base
    "'%s'."), "{prog} clean packages").format(prog=dnf.util.MAIN_PROG)

AttributeError: 'NoneType' object has no attribute 'format'
karma

This breaks anaconda - an installer image built with this DNF fails to successfully complete an install, with this traceback:

08:02:48,050 CRT exception: Traceback (most recent call last):

  File "/usr/lib64/python3.7/site-packages/pyanaconda/threading.py", line 280, in run
    threading.Thread.run(self)

  File "/usr/lib64/python3.7/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation.py", line 394, in run_installation
    queue.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 305, in start
    item.start()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 484, in start
    self.run_task()

  File "/usr/lib64/python3.7/site-packages/pyanaconda/installation_tasks.py", line 450, in run_task
    self._task(*self._task_args, **self._task_kwargs)

  File "/usr/lib64/python3.7/site-packages/pyanaconda/payload/dnfpayload.py", line 1404, in post_install
    self._base.close()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 466, in close
    self._finalize_base()

  File "/usr/lib/python3.7/site-packages/dnf/base.py", line 445, in _finalize_base
    "'%s'."), "{prog} clean packages").format(prog=dnf.util.MAIN_PROG)

AttributeError: 'NoneType' object has no attribute 'format'

then this should be on a blacklist so I can't build it. what am I supposed to do, ask puiterwijk before I build anything?

karma

Fix looks good in my testing.

karma

Fix looks good in my testing.

karma

Fix looks good in my testing.

karma

yup, it does.

karma

was in f31 final candidate, passed testing, must be pushed.

karma

this was in F31 final candidate and it's passed testing, so we need to push it.

Looks good to me, I tested and was able to confirm this seems to address both #1747408 and #1758588.

@egreshko, this update is not intended to address your specific case here.

BZ#1747408 Cannot upgrade to Fedora 31: package exa-0.9.0-2.module_f31+5365+04413d87.x86_64 requires libgit2.so.28()(64bit), but none of the providers can be installed
BZ#1758588 dnf system-upgrade reboot fails due to depresolv difference with download

-3 should fix the bug from -2, we hope.

I think this made things worse, so unpushing it for now.

karma

Tested by eyeball, the only change is this:

-Obsoletes:      %{name}-yum < %{version}-%{release}
+Obsoletes:      %{name}-yum < 5

and that looks good to me.

BZ#1760937 dnf-yum in F30 is now higher versioned than F31+ yum's "Obsoletes" (affects upgrades)
karma

openQA testing looks good, including manually triggered universal tests. Note the iSCSI failure is normal when running the tests this way - it's because the update installer image build test produces a netinst image, but the iSCSI test only works with a DVD image (one that contains packages) as the client end of the iSCSI test doesn't have network access to anything but the server so the server end has to provide a package repo for it, but it can only do that by using the packages from the DVD image...it's just an unfortunate limitation in the tests I can't really fix easily. So it doesn't mean this update broke stuff. Unfortunately we'll only be able to get a 'legit' iSCSI test result by pushing this stable and seeing what happens in the next compose.

seems fine in a quick test.

BZ#1761484 Update appstream-data after final freeze