Comments

22 Comments
karma

@jforbes, why does fedora delivers kernel with breaking changes in API to stable branch? This update has broken ZFS module, and now it does not compile.

In file included from /var/lib/dkms/zfs/0.7.12/build/include/zpios-internal.h:39,
                 from /var/lib/dkms/zfs/0.7.12/build/module/zpios/pios.c:42:
/var/lib/dkms/zfs/0.7.12/build/include/zpios-ctl.h: In function 'zpios_timespec_now':
/var/lib/dkms/zfs/0.7.12/build/include/zpios-ctl.h:186:11: error: implicit declaration of function 'current_kernel_time'; did you mean 'current_kernel_time64'? [-Werror=implicit-function-declaration]
  ts_now = current_kernel_time();
           ^~~~~~~~~~~~~~~~~~~
           current_kernel_time64
/var/lib/dkms/zfs/0.7.12/build/include/zpios-ctl.h:186:9: error: incompatible types when assigning to type 'struct timespec' from type 'int'
  ts_now = current_kernel_time();
         ^
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:292: /var/lib/dkms/zfs/0.7.12/build/module/zpios/pios.o] Error 1
make[4]: *** [scripts/Makefile.build:516: /var/lib/dkms/zfs/0.7.12/build/module/zpios] Error 2

Only had to change font config for urxvt from

URxvt.font:       -*-terminus-medium-*-*-*-*-140-*-*-*-*-*-*
URxvt.boldFont:   -*-terminus-bold-*-*-*-*-140-*-*-*-*-*-*

to

URxvt.font:       xft:Terminus:pixelsize=14
URxvt.boldFont:   xft:Terminus:bold:pixelsize=14
BZ#1664054 Terminus fonts apparently corrupted
BZ#1636462 mkvtoolnix-27.0.0 is available

Thanks for fixing #1575520

Seems like it still failing when doing CTRL-D in octave-cli :(

$ gdb /usr/bin/octave-cli-4.2.2 
GNU gdb (GDB) Fedora 8.1-11.fc29
.....
Reading symbols from /usr/bin/octave-cli-4.2.2...Reading symbols from /usr/lib/debug/usr/bin/octave-cli-4.2.2-4.2.2-1.fc29.x86_64.debug...done.
done.
(gdb) run
Starting program: /usr/bin/octave-cli-4.2.2 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
GNU Octave, version 4.2.2
... hitting CTRL-D ...

octave:1> /usr/include/c++/8/bits/basic_string.h:1048: std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator[](std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference = char&; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type = long unsigned int]: Assertion '__pos <= size()' failed.

Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=0x6) at ../sysdeps/unix/sysv/linux/raise.c:50
50    return ret;
(gdb) bt
#0  __GI_raise (sig=sig@entry=0x6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ffff446d5c1 in __GI_abort () at abort.c:79
#2  0x00007ffff72349c8 in std::__replacement_assert (__file=__file@entry=0x7ffff78c9008 "/usr/include/c++/8/bits/basic_string.h", __line=__line@entry=0x418, __function=__function@entry=0x7ffff78f4880 <_ZZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEixEmE19__PRETTY_FUNCTION__> "std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator[](std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type) [with _Ch"..., __condition=__condition@entry=0x7ffff78c92a9 "__pos <= size()") at /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2389
#3  0x00007ffff76c5fb8 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::operator[] (__pos=<optimized out>, this=0x7fffffffd280) at libinterp/corefcn/load-path.h:91
#4  octave_base_reader::octave_gets[abi:cxx11](bool&) () at libinterp/corefcn/input.cc:301
#5  0x00007ffff76c6014 in octave_terminal_reader::get_input[abi:cxx11](bool&) (this=<optimized out>, eof=<optimized out>) at libinterp/corefcn/input.cc:737
#6  0x00007ffff739e733 in octave_input_reader::get_input[abi:cxx11](bool&) (this=0x5555558f50a0, eof=@0x7fffffffd27f: 0x1) at libinterp/corefcn/input.h:267
#7  octave::lexer::fill_flex_buffer (this=0x5555558f4d60, buf=0x555555bcdc00 "", max_size=0x2000) at /home/jwe/src/octave-stable/libinterp/parse-tree/lex.ll:3591
#8  0x00007ffff739d1d0 in yy_get_next_buffer (yyscanner=yyscanner@entry=0x555555bca2d0) at libinterp/parse-tree/lex.cc:3430
#9  0x00007ffff73a44e6 in octave_lex(OCTAVE_STYPE*, void*) () at libinterp/parse-tree/lex.cc:3270
#10 0x00007ffff73b739e in octave_pull_parse (yyps=0x555555924250, parser=...) at libinterp/parse-tree/oct-parse.cc:2973
#11 0x00007ffff73b745c in octave::parser::run() () at libinterp/parse-tree/oct-parse.yy:4045
#12 0x00007ffff76d0b1d in octave::interpreter::main_loop() () at libinterp/corefcn/interpreter.cc:885
#13 0x00007ffff76d1798 in octave::interpreter::execute() () at libinterp/corefcn/interpreter.cc:759
#14 0x00005555555551ce in main () at src/main-cli.cc:90
#15 0x00007ffff446f1eb in __libc_start_main (main=0x555555555090 <main>, argc=0x1, argv=0x7fffffffdd98, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffdd88) at ../csu/libc-start.c:308
#16 0x000055555555540a in _start () at src/main-cli.cc:91
(gdb) frame 4
#4  octave_base_reader::octave_gets[abi:cxx11](bool&) () at libinterp/corefcn/input.cc:301
301       if (retval[retval.length () - 1] != '\n')
(gdb) p retval.size()
$1 = 0x0
(gdb) p retval.length () - 1
$2 = 0xffffffffffffffff
(gdb) 

The master branch has it fixed it seems, at least they doen't do that crazy "last index" calculations anymore: http://hg.savannah.gnu.org/hgweb/octave/annotate/057a894914df/libinterp/corefcn/input.cc#l263

@orion, does it worth to open a ticket with request to backport the fix? Or better just wait for the next release and do not use CTRL-D?

This update has been unpushed.

There was new release already https://bugzilla.redhat.com/show_bug.cgi?id=1539671

Scott, could you include that into this update?

Anything specific you are waiting for?

BZ#1421394 hackrf-2017.02.1 is available
BZ#1531464 Review Request: php-pecl-couchbase2 - Couchbase Server PHP extension
BZ#1531464 Review Request: php-pecl-couchbase2 - Couchbase Server PHP extension

The soname is different, because I've convinced upstream to version shared object, and previous version managed to reach stable with 0.0.0.

This update has been unpushed.

BZ#1508384 Review Request: git-publish - Prepare and store patch revisions as git tags

Would be cool to have manpage included, even if it will be autogenerated by help2man git-publish