Comments
dmoluguw
Works on my local system. The failures-only option is not provided by pki-healthcheck and so this option is not available. This will be fixed in a future version of pki-healthcheck. Thanks for the update!
(tested on f32 but will affect f31 as well) This breaks pki-healthcheck:
[root@mkd /tmp/test] # pki-healthcheck
Traceback (most recent call last):
File "/usr/sbin/pki-healthcheck", line 11, in <module>
load_entry_point('pkihealthcheck==0.1', 'console_scripts', 'pki-healthcheck')()
File "/usr/lib/python3.8/site-packages/pki/server/healthcheck/core/main.py", line 31, in main
sys.exit(checks.run_healthcheck())
File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/core.py", line 280, in run_healthcheck
output = out(options)
File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/output.py", line 102, in __init__
super(JSON, self).__init__(options)
File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/output.py", line 40, in __init__
self.failures_only = options.failures_only
AttributeError: 'Namespace' object has no attribute 'failures_only'
[root@mkd /tmp/test] # rpm -qa | grep healthcheck
freeipa-healthcheck-0.6-2.fc32.noarch
freeipa-healthcheck-core-0.6-2.fc32.noarch
This breaks pki-healthcheck:
[root@mkd /tmp/test] # pki-healthcheck
Traceback (most recent call last):
File "/usr/sbin/pki-healthcheck", line 11, in <module>
load_entry_point('pkihealthcheck==0.1', 'console_scripts', 'pki-healthcheck')()
File "/usr/lib/python3.8/site-packages/pki/server/healthcheck/core/main.py", line 31, in main
sys.exit(checks.run_healthcheck())
File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/core.py", line 280, in run_healthcheck
output = out(options)
File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/output.py", line 102, in __init__
super(JSON, self).__init__(options)
File "/usr/lib/python3.8/site-packages/ipahealthcheck/core/output.py", line 40, in __init__
self.failures_only = options.failures_only
AttributeError: 'Namespace' object has no attribute 'failures_only'
[root@mkd /tmp/test] # rpm -qa | grep healthcheck
freeipa-healthcheck-0.6-2.fc32.noarch
freeipa-healthcheck-core-0.6-2.fc32.noarch
The upstream 0.5 works with PKI healthcheck tool. This version was already released on F31 which hit stable already.
This update works along with python-astroid to fix the pylint issue. This works in my local as well as my COPR.
This update needs python-lazy-object-proxy update to fix the pylint issue. This works in my local as well as my COPR.
This update fixes our CI pipeline
Before building: Build on Fedora 31 fails With this update: F31 succeeds
PS: I built python-astroid from the srpm in the koji, in my COPR
This update has been unpushed.
Pushing to stable since OpenQA has PASSED: https://openqa.fedoraproject.org/tests/431657
This update has been unpushed.
This is a weird error since openQA tests with a conflicting version of IPA. This new PKI package requires IPA >= 4.7.1
A specific conflict was declared in PKI: https://github.com/dogtagpki/pki/blob/master/pki.spec#L679
But, open QA tests with FreeIPA 4.7.0: https://openqa.fedoraproject.org/tests/314576#step/_advisory_update/21
Since freeIPA 4.5.1 doesn't exist yet in bodhi, the errors occurred. Regardless, OpenQA must have reported a different error.
The issue that we see in OpenQA isn't reproducible in a normal dev/CI environment. We need to look why we get the following error:
java.lang.NoSuchMethodError: com.netscape.certsrv.apps.CMS.getLogger()Lcom/netscape/certsrv/logging/ILogger;
We don't depend on CMS.getLogger()any more. We try to instantiate a slf4j logger in its place.
@adamwill, can you rerun the FreeIPA test since tomcatjss-7.3.6-1.fc28 is now available in stable?
As per our discussion, tomcatjss 7.3.6-1 will be hitting stable within a day. So, we will be rerunning the ipa tests once it gets pushes to stable.
Reason: To keep the tomcatjss' release number in sync with Fedora releases.
Can you provide us more info: - Which version of FreeIPA does this update break? - Can we get more access to the logs?
Tested this on my local system with F32.
I took a look at the upstream code changes and seems to fix both F31 and F32. The
failures-only optionis not provided bypki-healthcheckand so this option is not available. This will be fixed in a future version ofpki-healthcheck. Thanks for the update!