Comments

22 Comments
karma

All unit tests it provides passed, +1

karma

+1

BZ#1685441 Unescaped left brace in regex is deprecated
karma

+1

karma

Looks good, passed all unit tests.

karma

Works for me, +1

karma

Works for me, +1

karma

Looks good, passed unit test

karma

Works for me, +1

BZ#1659217 mutt does not correctly decode PGP emails
karma

+1

BZ#1678628 lollypop-0.9.921 is available
BZ#1681624 lollypop-0.9.922 is available

Just wonder it's okay to mark it as 0.4.9 even though there isn't the version in the upstream.

karma

LGTM, passed all tests.

karma

LGTM, passed all tests.

karma

LGTM, passed all tests.

karma

No test issues with the source from fedora repository and tasks as @marcinslusarz said.

LGTM, passed all tests.

With its source code compile, make test on failure.

Running tests...
Test project /home/tester/pmdk-convert/build
      Start  1: 1.0_pool_conversion
 1/15 Test  #1: 1.0_pool_conversion ....................................................................   Passed    4.21 sec
      Start  2: 1.1_pool_conversion
 2/15 Test  #2: 1.1_pool_conversion ....................................................................   Passed    3.64 sec
      Start  3: 1.2_pool_conversion
 3/15 Test  #3: 1.2_pool_conversion ....................................................................   Passed    3.34 sec
      Start  4: 1.3_pool_conversion
 4/15 Test  #4: 1.3_pool_conversion ....................................................................   Passed    3.16 sec
      Start  5: 1.4_pool_conversion
 5/15 Test  #5: 1.4_pool_conversion ....................................................................   Passed    3.15 sec
      Start  6: cli_test
 6/15 Test  #6: cli_test ...............................................................................   Passed    0.37 sec
      Start  7: tx_intr_single_file_pools
 7/15 Test  #7: tx_intr_single_file_pools ..............................................................***Failed    1.37 sec
      Start  8: tx_intr_single_file_poolsets
 8/15 Test  #8: tx_intr_single_file_poolsets ...........................................................***Failed    1.34 sec
      Start  9: tx_intr_multi_file_poolsets
 9/15 Test  #9: tx_intr_multi_file_poolsets ............................................................***Failed    1.51 sec
      Start 10: tx_intr_poolsets_with_local_replica
10/15 Test #10: tx_intr_poolsets_with_local_replica ....................................................***Failed    2.14 sec
      Start 11: poolsets_with_remote_replica
11/15 Test #11: poolsets_with_remote_replica ...........................................................   Passed    0.17 sec
      Start 12: tx_intr_single_file_pools_devdax_SKIP_BECAUSE_OF_NO_DEVDAX_DEFINED
12/15 Test #12: tx_intr_single_file_pools_devdax_SKIP_BECAUSE_OF_NO_DEVDAX_DEFINED .....................   Passed    0.01 sec
      Start 13: tx_intr_single_file_poolsets_devdax_SKIP_BECAUSE_OF_NO_DEVDAX_DEFINED
13/15 Test #13: tx_intr_single_file_poolsets_devdax_SKIP_BECAUSE_OF_NO_DEVDAX_DEFINED ..................   Passed    0.01 sec
      Start 14: tx_intr_multi_file_poolsets_devdax_SKIP_BECAUSE_OF_NOT_ENOUGH_DEVDAX_DEFINED
14/15 Test #14: tx_intr_multi_file_poolsets_devdax_SKIP_BECAUSE_OF_NOT_ENOUGH_DEVDAX_DEFINED ...........   Passed    0.01 sec
      Start 15: tx_intr_poolsets_with_local_replica_devdax_SKIP_BECAUSE_OF_NOT_ENOUGH_DEVDAX_DEFINED
15/15 Test #15: tx_intr_poolsets_with_local_replica_devdax_SKIP_BECAUSE_OF_NOT_ENOUGH_DEVDAX_DEFINED ...   Passed    0.01 sec

73% tests passed, 4 tests failed out of 15

Total Test time (real) =  24.47 sec

The following tests FAILED:
      7 - tx_intr_single_file_pools (Failed)
      8 - tx_intr_single_file_poolsets (Failed)
      9 - tx_intr_multi_file_poolsets (Failed)
     10 - tx_intr_poolsets_with_local_replica (Failed)
Errors while running CTest
make: *** [Makefile:109: test] Error 8

LGTM, passed all tests.

karma

LGTM, passed all tests.