add upstream patches for GNOME 3.18
sudo dnf upgrade --advisory=FEDORA-2016-7d556fdafa
This update has been submitted for testing by raphgro.
This update resolve bug #1307253 for me, but there are new problems with this new version.
python doesn't crash anymore, but when running hamster from console, I get:
/usr/lib/python2.7/site-packages/hamster/lib/configuration.py:33: PyGIWarning: GConf was imported without specifying a version first. Use gi.require_version('GConf', '2.0') before import to ensure that the right version gets loaded.
from gi.repository import GConf as gconf
Traceback (most recent call last):
File "/usr/bin/hamster", line 387, in <module>
File "/usr/bin/hamster", line 152, in overview
File "/usr/bin/hamster", line 143, in _launch_window
File "/usr/lib64/python2.7/site-packages/dbus/proxies.py", line 70, in __call__
return self._proxy_method(*args, **keywords)
File "/usr/lib64/python2.7/site-packages/dbus/proxies.py", line 145, in __call__
File "/usr/lib64/python2.7/site-packages/dbus/connection.py", line 651, in call_blocking
dbus.exceptions.DBusException: org.freedesktop.DBus.Python.ZeroDivisionError: Traceback (most recent call last):
File "/usr/lib64/python2.7/site-packages/dbus/service.py", line 707, in _message_cb
retval = candidate_method(self, *args, **keywords)
File "/usr/bin/hamster-windows-service", line 38, in overview
def overview(self): dialogs.overview.show(self.app)
File "/usr/lib/python2.7/site-packages/hamster/lib/configuration.py", line 149, in show
dialog = self.get_dialog_class()(parent, **kwargs)
File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 417, in __init__
File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 455, in find_facts
File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 305, in set_facts
self.stacked_bar.set_items([(cat, delta.total_seconds() / 60.0) for cat, delta in totals['category']])
File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 136, in set_items
res.append((key, val, val * 1.0 / max_value))
ZeroDivisionError: float division by zero
I'd like to retract my previous comment: Without changing anything, hamster now works. Maybe this was an artifact of a service of the previous version that was still running.
Thanks for testing. Please let me know when you can reproduce the above exception with ZeroDivisionError and what you've done. The PyGIWarning is quite normal (I get it also) and just indicate bad coding style of upstream.
Your comment about the need to restart services is somehow useful to know, should we recommend users to logout and login?
I'm not sure if hamster-service and hamster-windows-service are restarted on upgrade. If they aren't, it would probably be helpful to restart them.
Both background services are not restarted. I'm not sure if upstream provides a clean way to restart them.
Btw: The warning started to appear only since Gnome 3.18 so it's more a sign of "recently deprecated" coding patterns rather than "bad coding style".
hamster-service stops itself after it is changed (but I think not when any other file that is used by the service is updated, so I'm not sure it is sufficient): https://github.com/projecthamster/hamster/blob/master/src/hamster-service#L87
However, it has a Quit method that is callable through DBUS: https://github.com/projecthamster/hamster/blob/master/src/hamster-service#L119
hamster-windows-service doesn't stop after a change, but also has a Quit method: https://github.com/projecthamster/hamster/blob/master/src/hamster-windows-service#L28
These could be called after an update to shut down the old version. The next use of the services should respawn them (at least this is what the source says; I have no experience with DBUS).
This update has been pushed to testing.
This update has been submitted for stable by bodhi.
Works well here.
raphgro edited this update.
Thank you for the fix! Functionnal for me.
I can't tell about relaunching the deamon, I tried installing it from sources, and I killed both before reinstalling from testing.
This update has been pushed to stable.
Please login to add feedback.
Copyright © 2007-2019 Red Hat, Inc. and
bodhi is Free Software.
if you have any problems. Read the documentation.