add upstream patches for GNOME 3.18

  • workaround for a segfault in glib/gio
  • prevent warnings with introspection
  • #1074967
  • #1307256

Logout Required
After installing this update it is required that you logout of your current user session and log back in to ensure the changes supplied by this update are applied properly.

How to install

sudo dnf upgrade --advisory=FEDORA-2016-7d556fdafa

This update has been submitted for testing by raphgro.

3 years ago
User Icon rabiny commented & provided feedback 3 years ago

This update resolve bug #1307253 for me, but there are new problems with this new version.

User Icon seither commented & provided feedback 3 years ago
karma

python doesn't crash anymore, but when running hamster from console, I get:

/usr/lib/python2.7/site-packages/hamster/lib/configuration.py:33: PyGIWarning: GConf was imported without specifying a version first. Use gi.require_version('GConf', '2.0') before import to ensure that the right version gets loaded.
  from gi.repository import GConf as gconf
Traceback (most recent call last):
  File "/usr/bin/hamster", line 387, in <module>
    hamster_client.overview()
  File "/usr/bin/hamster", line 152, in overview
    self._launch_window("overview")
  File "/usr/bin/hamster", line 143, in _launch_window
    getattr(server, window_name)()
  File "/usr/lib64/python2.7/site-packages/dbus/proxies.py", line 70, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib64/python2.7/site-packages/dbus/proxies.py", line 145, in __call__
    **keywords)
  File "/usr/lib64/python2.7/site-packages/dbus/connection.py", line 651, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Python.ZeroDivisionError: Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/dbus/service.py", line 707, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/usr/bin/hamster-windows-service", line 38, in overview
    def overview(self): dialogs.overview.show(self.app)
  File "/usr/lib/python2.7/site-packages/hamster/lib/configuration.py", line 149, in show
    dialog = self.get_dialog_class()(parent, **kwargs)
  File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 417, in __init__
    self.find_facts()
  File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 455, in find_facts
    self.totals.set_facts(self.facts)
  File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 305, in set_facts
    self.stacked_bar.set_items([(cat, delta.total_seconds() / 60.0) for cat, delta in totals['category']])
  File "/usr/lib/python2.7/site-packages/hamster/overview.py", line 136, in set_items
    res.append((key, val, val * 1.0 / max_value))
ZeroDivisionError: float division by zero
BZ#1307256 [abrt] hamster-time-tracker: strlen(): python2.7 killed by SIGSEGV
User Icon seither commented & provided feedback 3 years ago
karma

I'd like to retract my previous comment: Without changing anything, hamster now works. Maybe this was an artifact of a service of the previous version that was still running.

BZ#1307256 [abrt] hamster-time-tracker: strlen(): python2.7 killed by SIGSEGV
User Icon raphgro commented & provided feedback 3 years ago

Thanks for testing. Please let me know when you can reproduce the above exception with ZeroDivisionError and what you've done. The PyGIWarning is quite normal (I get it also) and just indicate bad coding style of upstream. Your comment about the need to restart services is somehow useful to know, should we recommend users to logout and login?

User Icon seither commented & provided feedback 3 years ago

I'm not sure if hamster-service and hamster-windows-service are restarted on upgrade. If they aren't, it would probably be helpful to restart them.

User Icon fschwarz commented & provided feedback 3 years ago

Both background services are not restarted. I'm not sure if upstream provides a clean way to restart them.

Btw: The warning started to appear only since Gnome 3.18 so it's more a sign of "recently deprecated" coding patterns rather than "bad coding style".

User Icon seither commented & provided feedback 3 years ago

hamster-service stops itself after it is changed (but I think not when any other file that is used by the service is updated, so I'm not sure it is sufficient): https://github.com/projecthamster/hamster/blob/master/src/hamster-service#L87

However, it has a Quit method that is callable through DBUS: https://github.com/projecthamster/hamster/blob/master/src/hamster-service#L119

hamster-windows-service doesn't stop after a change, but also has a Quit method: https://github.com/projecthamster/hamster/blob/master/src/hamster-windows-service#L28

These could be called after an update to shut down the old version. The next use of the services should respawn them (at least this is what the source says; I have no experience with DBUS).

This update has been pushed to testing.

3 years ago

This update has been submitted for stable by bodhi.

3 years ago
User Icon amigadave commented & provided feedback 3 years ago
karma

Works well here.

BZ#1307253 [abrt] hamster-time-tracker: connection.py:651:call_blocking:DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name :1.637 was not provided by any .service files
BZ#1307256 [abrt] hamster-time-tracker: strlen(): python2.7 killed by SIGSEGV

raphgro edited this update.

3 years ago
User Icon anonymous commented & provided feedback 3 years ago

Thank you for the fix! Functionnal for me.
I can't tell about relaunching the deamon, I tried installing it from sources, and I killed both before reinstalling from testing.

karma: +1

BZ#1307256 [abrt] hamster-time-tracker: strlen(): python2.7 killed by SIGSEGV

This update has been pushed to stable.

3 years ago

Please login to add feedback.

Metadata
Type
security
Severity
high
Karma
2
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-4
Stable by Karma
2
Dates
submitted
3 years ago
in testing
3 years ago
in stable
3 years ago
modified
3 years ago
BZ#1307253 [abrt] hamster-time-tracker: connection.py:651:call_blocking:DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name :1.637 was not provided by any .service files
0
1
BZ#1307256 [abrt] hamster-time-tracker: strlen(): python2.7 killed by SIGSEGV
0
2

Automated Test Results