FEDORA-2018-a5e9a619f6 created by kdudka 3 years ago for Fedora 28
stable

update to latest upstream release, which fixes the following vulnerabilities:

  • CVE-2018-1100 - stack-based buffer overflow in utils.c:checkmailpath()
  • CVE-2018-1083 - stack-based buffer overflow in compctl.c:gen_matches_files()
  • CVE-2018-1071 - stack-based buffer overflow in exec.c:hashcmd()

How to install

sudo dnf upgrade --advisory=FEDORA-2018-a5e9a619f6

This update has been submitted for testing by kdudka.

3 years ago

This update has been pushed to testing.

3 years ago
User Icon garrettl commented & provided feedback 3 years ago
karma

zsh 5.5-1.fc28 seems to be lacking built-in functions, causing things like zgen, zplug, and oh-my-zsh to not function properly.

On zsh-5.4.2-7.fc28.x86_64, zgen (what I use for plugins) works. After upgrading to zsh-5.5-1.fc28.x86_64, I get the following if I just have zgen sourced, but no other modules (not a realistic scenario, but a simple one):

/home/garrett/.zgen/init.zsh:13: compinit: function definition file not found

If I have modules from zgen installed (including ones from oh-my-zsh), I get the following with zsh 5.5:

/home/garrett/.zgen/robbyrussell/oh-my-zsh-master/lib/theme-and-appearance.zsh:2: colors: function definition file not found
/home/garrett/.zgen/robbyrussell/oh-my-zsh-master/oh-my-zsh.sh:77: compinit: function definition file not found
zsh: compdef: command not found...
zsh: compdef: command not found...
[...compdef error repeats several more times...]
/home/garrett/.zgen/zsh-users/zsh-syntax-highlighting-master/zsh-syntax-highlighting.zsh:59: is-at-least: function definition file not found
zsh-syntax-highlighting: Failed to load add-zsh-hook. Some speed optimizations will not be used.
zsh-syntax-highlighting: failed loading add-zsh-hook.
/home/garrett/.zgen/init.zsh:42: compinit: function definition file not found

So the following built-in functions (and probably more) seem to be broken in the zsh 5.5 RPM:

  • compinit
  • compdef
  • is-at-least
  • add-zsh-hook

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

3 years ago

I am pretty sure those functions are contained in zsh-5.5:

% rpm -lq zsh | grep -E 'compinit|compdef|is-at-least|add-zsh-hook'
/usr/share/zsh/5.5/functions/_add-zsh-hook
/usr/share/zsh/5.5/functions/_compdef
/usr/share/zsh/5.5/functions/add-zsh-hook
/usr/share/zsh/5.5/functions/bashcompinit
/usr/share/zsh/5.5/functions/compinit
/usr/share/zsh/5.5/functions/is-at-least

Did you (re)exec zsh in your already running sessions?

In a login session, you need to do something like this:

% exec zsh -l

This was discussed at https://bugzilla.redhat.com/1296692 where we agreed to not rebase zsh in stable Fedora releases to avoid troubles like this. However, f28 is not stable yet, so this is acceptable IMO.

I still hit the error on both my work and personal laptop, also after exec'ing like you suggest.

This is from my personal laptop:

exec zsh -l
/home/garrett/.zgen/robbyrussell/oh-my-zsh-master/lib/theme-and-appearance.zsh:2: colors: function definition file not found
/home/garrett/.zgen/robbyrussell/oh-my-zsh-master/oh-my-zsh.sh:77: compinit: function definition file not found
zsh: compdef: command not found...
...

I'm pretty sure it also persists even after a reboot. I'll reboot my laptop and try again after posting this.

(Oh, I guess I have two FAS accounts by accident. I thought it was a bit odd that it wouldn't log me into this one and said my name was 'garrettl' and not 'garrett'. Anyway...)

User Icon garrettl commented & provided feedback 3 years ago
karma

After rebooting, it works. Sorry for the noise.

Changing to +1s on this other account (and then will log out and back into my normal account, but that's irrelevant to this).

This update has reached 3 days in testing and can be pushed to stable now if the maintainer wishes

3 years ago
User Icon cserpentis commented & provided feedback 3 years ago
karma

works for me

Thanks for testing! There is going to be a minor upstream release this evening:

http://www.zsh.org/mla/workers/2018/msg00461.html

So I will probably replace the build in this update.

User Icon pwalter commented & provided feedback 3 years ago
karma

Works

This update has been submitted for stable by pwalter.

3 years ago

This update has been pushed to stable.

3 years ago

Please login to add feedback.

Metadata
Type
security
Severity
medium
Karma
3
Signed
Content Type
RPM
Test Gating
Builds
1
Settings
Unstable by Karma
-3
Stable by Karma
disabled
Stable by Time
disabled
Dates
submitted
3 years ago
in testing
3 years ago
in stable
3 years ago
BZ#1553533 CVE-2018-1071 zsh: Stack-based buffer overflow in exec.c:hashcmd() [fedora-all]
0
0
BZ#1560696 CVE-2018-1083 zsh: Stack-based buffer overflow in gen_matches_files() at compctl.c [fedora-all]
0
0
BZ#1563396 CVE-2018-1100 zsh: buffer overflow in utils.c:checkmailpath() can lead to local arbitrary code execution [fedora-all]
0
0
BZ#1564936 zsh-5.5 is available
0
0

Automated Test Results