stable

FEDORA-2018-d4d38d8885 created by pjones 3 years ago for Fedora 29

Fixes the code that creates our boot counting configuration snippet. This fix won't take effect until grub2-mkconfig is re-run.

How to install

sudo dnf upgrade --refresh --advisory=FEDORA-2018-d4d38d8885

This update has been submitted for testing by pjones.

3 years ago

This update has been pushed to testing.

3 years ago
User Icon pbrobinson commented & provided feedback 3 years ago
karma

Boots fine on Carbon X1g6 w/ secure boot, UP², mustang, RPi3B+, Pine64, Firefly339, Rock960 and probably a few others I missed

BZ#1614637 Broken bash syntax in /etc/grub.d/01_fallback_counting
User Icon adamwill commented & provided feedback 3 years ago

This appears to break initial install. Some netinst tests failed in the Fedora-29-20181002.n.0 compose openQA testing, like this one:

https://openqa.fedoraproject.org/tests/287990

They failed with bootloader install error, program.log shows:

01:42:30,298 INF program: Generating grub configuration file ...
01:42:30,299 INF program: /etc/grub.d/01_fallback_counting: line 4: ${boot_counter}-1: syntax error: operand expected (error token is "${boot_counter}-1")
01:42:30,300 DBG program: Return code: 1

Those tests seem to have installed this version of grub2 (as it was in updates-testing at the time they ran). In comparison, DVD install tests that deployed the previous build (-59) worked fine.

User Icon miabbott commented & provided feedback 3 years ago
karma

This appears to break rpm-ostree install functionality on F29 Atomic Host. Specifically, the writing out of the bootloader as the final piece of the install operation.

# rpm-ostree status
State: idle
AutomaticUpdates: disabled
Deployments:
● ostree://fedora-atomic:fedora/29/x86_64/testing/atomic-host
                   Version: 29.20181003.0 (2018-10-03 14:59:08)
                    Commit: 5dbe63cb0db058eedba63e645df08ff4c0b0b4a8bf20e1862e4921b5232cd5d1
              GPGSignature: Valid signature by 5A03B4DD8254ECA02FDA1637A20AA56B429476B4

# rpm-ostree install wget
Checking out tree 5dbe63c... done
Enabled rpm-md repositories: updates-testing updates fedora
rpm-md repo 'updates-testing' (cached); generated: 2018-10-01 21:51:38
rpm-md repo 'updates' (cached); generated: 2018-02-20 19:18:14
rpm-md repo 'fedora' (cached); generated: 2018-10-02 09:59:20
Importing metadata [=============] 100%
Resolving dependencies... done
Checking out packages (1/1) [=============] 100%
Running pre scripts... 0 done
Running post scripts... 7 done
Writing rpmdb... done
Writing OSTree commit... done
Freed: 16.5 MB (pkgcache branches: 0)
Added:
  wget-1.19.5-5.fc29.x86_64
Run "systemctl reboot" to start a reboot

# ostree admin finalize-staged
error: Bootloader write config: grub2-mkconfig: Child process exited with code 1

See https://github.com/projectatomic/rpm-ostree/issues/1598 for more info

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

3 years ago

pjones edited this update.

New build(s):

  • grub2-2.02-61.fc29

Removed build(s):

  • grub2-2.02-60.fc29

Karma has been reset.

3 years ago

This update has been submitted for testing by pjones.

3 years ago

This update has been pushed to testing.

3 years ago

pjones edited this update.

New build(s):

  • grub2-2.02-62.fc29

Removed build(s):

  • grub2-2.02-61.fc29

Karma has been reset.

3 years ago

This update has been submitted for testing by pjones.

3 years ago

This update has been pushed to testing.

3 years ago
User Icon besser82 commented & provided feedback 3 years ago
karma

Works great! LGTM! =)

User Icon pbrobinson commented & provided feedback 3 years ago
karma

Seems fine on a number of x86_64 and aarcch64 devices

BZ#1614637 Broken bash syntax in /etc/grub.d/01_fallback_counting
User Icon cserpentis commented & provided feedback 3 years ago
karma

works for me

User Icon pwalter commented & provided feedback 3 years ago
karma

Works

User Icon cairo provided feedback 3 years ago
karma

This update has been submitted for batched by pjones.

3 years ago

This update has been submitted for stable by pwalter.

3 years ago

This update has been pushed to stable.

3 years ago

Please login to add feedback.

Metadata
Type
enhancement
Karma
5
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
disabled
Stable by Time
disabled
Dates
submitted
3 years ago
in testing
3 years ago
in stable
3 years ago
modified
3 years ago
BZ#1614637 Broken bash syntax in /etc/grub.d/01_fallback_counting
0
1

Automated Test Results