FEDORA-2019-10b951e545 created by sgallagh 2 years ago for Fedora 30
stable

Improvements to ModuleIndex.update_from_defaults_directory()

  • Import each file in the directory as a merge rather than an overwrite so we can detect conflicts.
  • Modify the meaning of the 'strict' argument to fail if the merge would result in a conflict in the default stream setting of a module.

How to install

sudo dnf upgrade --advisory=FEDORA-2019-10b951e545

This update has been submitted for testing by sgallagh.

2 years ago

This update's test gating status has been changed to 'waiting'.

2 years ago

This update's test gating status has been changed to 'ignored'.

2 years ago

This update has been pushed to testing.

2 years ago
User Icon lsedlar commented & provided feedback 2 years ago
karma

The patch works as expected. However I'm getting a warning when running the function on a directory that contains a YAML file that is not defaults (it's document: modulemd).

/home/lsedlar/pungi/pungi/util.py:944: Warning: g_propagate_error: assertion 'src != NULL' failed
  defaults_dir, overrides_path=overrides_dir, strict=True

The system remains functional, no issues noted.

User Icon chr77 commented & provided feedback 2 years ago
karma

Works for me. No regressions noted compared to previous version.

This update has been submitted for stable by bodhi.

2 years ago

@lsedlar Would you please file an issue at https://github.com/fedora-modularity/libmodulemd/issues and I'll fix it in the next release?

This update has been pushed to stable.

2 years ago

Please login to add feedback.

Metadata
Type
bugfix
Severity
low
Karma
2
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
2
Stable by Time
7 days
Dates
submitted
2 years ago
in testing
2 years ago
in stable
2 years ago

Automated Test Results