unpushed

gpsbabel-1.6.0-1.fc30

FEDORA-2019-28f1a34db2 created by corsepiu 4 years ago for Fedora 30

Upstream update

This update has been submitted for testing by corsepiu.

4 years ago

This update has been pushed to testing.

4 years ago

This update has reached 7 days in testing and can be pushed to stable now if the maintainer wishes

4 years ago
User Icon tsteven4 commented & provided feedback 4 years ago
karma

In /usr/share/applications/gpsbabel.desktop the Exec should be gpsbabelfe, not gpsbabelfe-bin.

User Icon tsteven4 commented & provided feedback 4 years ago

In addition to gpsbabelfe_.qm you should distribute gpsbabel_.qm. gpsbabelfe uses both translation files.

User Icon tsteven4 commented & provided feedback 4 years ago

that should be gpsbabelfe_*.qm and gpsbabel_*.qm

This update has been submitted for batched by corsepiu.

4 years ago
User Icon corsepiu commented & provided feedback 4 years ago

Are you trying to say gui/coretool/gpsbabel_*.qm should be installed to /usr/share/qt5/translations/ as part of the gpsbabel-package?

This update has been unpushed.

User Icon tsteven4 commented & provided feedback 4 years ago

I am saying that gui/coretool/gpsbabel_*.qm should be installed to /usr/share/qt5/translations/ as part of the gpsbabel-gui package.

gpsbabel-gui installs gpsbabelfe which uses both gpsbabelfe_.qm and gpsbabel_.qm translation files. The gpsbabel_*.qm files are translations of strings produced by the command line gpsbabel that gpsbabelfe may see and translate.

Alternatively,

If you

cd gui

qmake

make package

then on linux all the bits (except the desktop file) will be gathered for you under gui/GPSBabelFE

The package target is new to 1.6.0.

User Icon tsteven4 commented & provided feedback 4 years ago

There are two additional problem with translations besides supplying the gpsbabelfe_.qm and gpsbabel_.qm files.

  • you need a patch analogous to 0003-gpsbabel-1.4.3-gmapbase.patch. This is due to how Fedora packages gpsbabel.
diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index ea995ad6..ee79ce1c 100644
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -78,6 +78,9 @@ const int BabelData::deviceType_ = 1;

 #define FAKE_LANGUAGE_MENU 0

+#ifndef QTTRANSLATIONDIR
+#define QTTRANSLATIONDIR "/usr/share/qt5/translations"
+#endif
 //------------------------------------------------------------------------
 QString MainWindow::findBabelVersion()
 {
@@ -222,8 +225,7 @@ MainWindow::MainWindow(QWidget* parent): QMainWindow(parent)

   ui_.outputWindow->setReadOnly(true);

-  langPath_ = QApplication::applicationDirPath();
-  langPath_.append("/translations/");
+  langPath_ = QTTRANSLATIONDIR;

   // Start up in the current system language.
   loadLanguage(QLocale::system().name());

diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index ea995ad6..7f53c4f1 100644
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -314,10 +314,8 @@ void MainWindow::switchTranslator(QTranslator& translator, const QString& filena
   // remove the old translator
   qApp->removeTranslator(&translator);

-  QString full_filename(langPath_ + "/" + filename);
-
   // load the new translator
-  if (translator.load(full_filename)) {
+  if (translator.load(filename, langPath_)) {
     qApp->installTranslator(&translator);
   }
 }
User Icon corsepiu commented & provided feedback 4 years ago

Thanks. I'll apply your patches to the next iteration of this package.


Please login to add feedback.

Metadata
Type
bugfix
Severity
low
Karma
1
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
3
Stable by Time
disabled
Dates
submitted
4 years ago
in testing
4 years ago
BZ#1337062 GPSbabel-gui does not offer the device /dev/ttyACM0
0
0
BZ#1632175 gpsbabel - remove minizip-compat dependency
0
0
BZ#1705691 gpsbabel-1.6.0 is available
0
0

Automated Test Results