stable

fedora-review-0.7.2-1.fc29

FEDORA-2019-aa89309322 created by ngompa 5 years ago for Fedora 29

Update to 0.7.2 and switch to Python 3

How to install

Updates may require up to 24 hours to propagate to mirrors. If the following command doesn't work, please retry later:

sudo dnf upgrade --refresh --advisory=FEDORA-2019-aa89309322

This update has been submitted for testing by ngompa.

5 years ago
User Icon besser82 commented & provided feedback 5 years ago
karma

Works great! LGTM! =)

User Icon ankursinha commented 5 years ago

Got an error here:

Finish: run

03-18 10:39 root         DEBUG        CheckRpmlintInstalled completed: 46.150 seconds
03-18 10:39 root         DEBUG    Running check: CheckRpmlintDebuginfo
03-18 10:39 root         DEBUG        CheckRpmlintDebuginfo completed: 0.002 seconds
03-18 10:39 root         DEBUG    Running check: CheckInitDeps
03-18 10:39 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 239, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 229, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 118, in _run_checks
    writedown=not Settings.no_report)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 378, in run_checks
    run_check(name)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 352, in run_check
    check.run()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", line 358, in run
    deps.init()
  File "/usr/lib/python3.7/site-packages/FedoraReview/deps.py", line 36, in init
    'dnf'])
  File "/usr/lib64/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib64/python3.7/subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType
03-18 10:39 root         ERROR    Exception down the road...(logs in /home/asinha/.cache/fedora-review.log)
03-18 10:39 root         DEBUG    Report completed:  500.607 seconds

The command-line was: $ fedora-review -b 1649059

$ fedora-review -V
fedora-review version 0.7.0 dfc9dd8 2019-03-17 14:56:47 -0400
external plugins:

Unsure if this is a fedora-review bug, so not giving -1 just yet.

User Icon jstanek commented 5 years ago

I have got the same error as @ankursinha on F29:

03-18 13:38 root         DEBUG        CheckRpmlintInstalled completed: 55.724 seconds
03-18 13:38 root         DEBUG    Running check: CheckRpmlintDebuginfo
03-18 13:38 root         DEBUG    Run command: rpmlint -f /tmp/tmp1yshmfv5 /home/jstanek/redhat/fedora-review/review-mako/results/mako-debuginfo-1.2-1.fc30.x86_64.rpm
03-18 13:38 root         DEBUG        CheckRpmlintDebuginfo completed: 1.120 seconds
03-18 13:38 root         DEBUG    Running check: CheckInitDeps
03-18 13:38 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 239, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 229, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 118, in _run_checks
    writedown=not Settings.no_report)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 378, in run_checks
    run_check(name)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 352, in run_check
    check.run()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", line 358, in run
    deps.init()
  File "/usr/lib/python3.7/site-packages/FedoraReview/deps.py", line 36, in init
    'dnf'])
  File "/usr/lib64/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib64/python3.7/subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType
03-18 13:38 root         ERROR    Exception down the road...(logs in /home/jstanek/.cache/fedora-review.log)
03-18 13:38 root         DEBUG    Report completed:  207.555 seconds

CLI: $ fedora-review --name=mako with mako.spec and mako-1.2-1.fc31.src.rpm from #1689634

User Icon hobbes1069 commented 5 years ago

Looking at the automated test output:

 {
               "arch" : "noarch",
               "code" : "DesktopIconFileMissing",
               "context" : {
                  "excerpt" : [
                     "Icon=scantailor"
                  ],
                  "lineno" : 6,
                  "path" : "/usr/share/fedora-review/test/desktop-file/scantailor.desktop"
               },
               "diag" : "Icon file <var>scantailor</var> not found",
               "subpackage" : "fedora-review-tests"
            },
            {
               "arch" : "noarch",
               "code" : "DesktopFileValidation",
               "context" : {
                  "path" : "/usr/share/fedora-review/test/scantailor.desktop"
               },
               "diag" : "hint: value item \"ImageProcessing\" in key \"Categories\" in group \"Desktop Entry\" can be extended with another category among the following categories: Education, or Science",
               "subpackage" : "fedora-review-tests"
            },

Is this a problem?

User Icon eclipseo commented & provided feedback 5 years ago
karma

Found the bug for which I am responsible for.

Current code is assuming the user pass the option --mock-config. If none is specified the mock command in deps.py fails. I sent a PR upstream but in the meantime, as a workaround, pass the --mock-config option to fedora-review (all your reviews should be done on fedora Rawhide so --mock-config fedora-rawhide-x86_64).

-1 karma for now while we fix the thingie.

PR: https://pagure.io/FedoraReview/pull-request/347 Bug: https://pagure.io/FedoraReview/issue/346

This update has been pushed to testing.

5 years ago

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

5 years ago
User Icon cserpentis commented & provided feedback 5 years ago
karma

works for me

ngompa edited this update.

New build(s):

  • fedora-review-0.7.1-1.fc29

Removed build(s):

  • fedora-review-0.7.0-1.fc29

Karma has been reset.

5 years ago

This update has been submitted for testing by ngompa.

5 years ago

ngompa edited this update.

5 years ago

This update has been pushed to testing.

5 years ago
User Icon defolos commented & provided feedback 5 years ago
karma

I get the same error as described here: https://pagure.io/FedoraReview/issue/349 when I run: fedora-review -b 1692070

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

5 years ago

ngompa edited this update.

New build(s):

  • fedora-review-0.7.1-2.fc29

Removed build(s):

  • fedora-review-0.7.1-1.fc29

Karma has been reset.

5 years ago

This update has been submitted for testing by ngompa.

5 years ago

This update has been pushed to testing.

5 years ago

This update has reached 7 days in testing and can be pushed to stable now if the maintainer wishes

5 years ago

ngompa edited this update.

New build(s):

  • fedora-review-0.7.2-1.fc29

Removed build(s):

  • fedora-review-0.7.1-2.fc29

Karma has been reset.

5 years ago

This update has been submitted for testing by ngompa.

5 years ago

This update has been pushed to testing.

5 years ago
User Icon ignatenkobrain provided feedback 5 years ago
karma
User Icon sergiomb commented & provided feedback 5 years ago
karma

works better than version 0.6.0

This update has reached 7 days in testing and can be pushed to stable now if the maintainer wishes

5 years ago

This update has been submitted for batched by ngompa.

5 years ago

This update has been submitted for stable by ngompa.

5 years ago

This update has been pushed to stable.

5 years ago

Please login to add feedback.

Metadata
Type
bugfix
Karma
2
Signed
Content Type
RPM
Test Gating
Autopush Settings
Unstable by Karma
-3
Stable by Karma
3
Stable by Time
disabled
Dates
submitted
5 years ago
in testing
5 years ago
in stable
5 years ago
modified
5 years ago
Builds
1
fedora-review-0.7.2-1.fc29
fedora-review-0.7.2-1.fc29

Automated Test Results

Copyright © 2007-2025 Red Hat, Inc. and others.

Running bodhi-server 8.3.0 on bodhi-web-177-vpch4.

bodhi is Free Software. Please file issues if you have any problems. Read the documentation.

• Composes • Legal • Privacy policy •