FEDORA-2020-2bfbbeec99 — bugfix update for terminator

stable

terminator-1.92-1.fc31

FEDORA-2020-2bfbbeec99 created by dmaphy 5 years ago for Fedora 31

This update brings the new Terminator release 1.92 to a Fedora box near you. This is the first release of the new Terminator Team at GitHub (https://github.com/gnome-terminator/terminator). It finally supports Python 3 and fixes a lot of bugs. You can find a detailed changelog here: https://github.com/gnome-terminator/terminator/blob/master/CHANGELOG.md

How to install

Updates may require up to 24 hours to propagate to mirrors. If the following command doesn't work, please retry later:

sudo dnf upgrade --refresh --advisory=FEDORA-2020-2bfbbeec99

This update has been submitted for testing by dmaphy.

5 years ago

This update's test gating status has been changed to 'waiting'.

5 years ago

This update's test gating status has been changed to 'ignored'.

5 years ago

mattrose provided feedback 5 years ago

karma

Test Case terminator split

This update has been pushed to testing.

5 years ago

ifas provided feedback 5 years ago

karma

Test Case terminator split

This update can be pushed to stable now if the maintainer wishes

5 years ago

This update has been submitted for stable by dmaphy.

5 years ago

This update has been pushed to stable.

5 years ago

davidcraven commented & provided feedback 5 years ago

karma

Upgrading from 1.91-10.fc31 to 1.92-1.fc31 broke two things for me:

1 My custom vertical split keybinding (Ctrl+Shift+z) no longer works. My custom horizontal split keybinding (Ctrl+Shift+a) still works, though.

2 Middle click paste suddenly shows the exact behaviour of this old bug:

selecting something anywhere (terminator or any other application window) and middle click pasting in any other application pastes the selection
selecting something anywhere (terminator or any other application window) and middle click pasting in terminator pastes the copy buffer (copied with Ctrl-c or right click > copy) instead of the selection

Both worked before. Upgrading to 1.92-2.fc31 did not fix either problem. Downgrading to 1.91-10.fc31 fixed both.

~/.config/terminator/config:

[global_config]
  borderless = True
  tab_position = hidden
  title_transmit_fg_color = "#c2a14d"
  title_transmit_bg_color = "#2e3436"
  title_receive_fg_color = "#2e3436"
  title_receive_bg_color = "#c2a14d"
  title_inactive_fg_color = "#888a85"
  title_inactive_bg_color = "#2e3436"
  inactive_color_offset = 0.902777777778
  always_split_with_profile = True
  title_font = Monospace 9
[keybindings]
  go_next = <Shift>Tab
  split_horiz = <Primary><Shift>a
  split_vert = <Primary><Shift>z
  close_term = <Primary><Shift>q
  close_window = <Primary><Shift><Alt>q
  next_tab = <Primary><Shift>Right
  prev_tab = <Primary><Shift>Left
[profiles]
  [[default]]
    visible_bell = True
    background_darkness = 0.95
    background_type = transparent
    cursor_blink = False
    cursor_shape = ibeam
    cursor_color = "#aaaaaa"
    font = Source Code Pro 10
    scrollbar_position = hidden
    scrollback_infinite = True
    palette = "#686868:#e50000:#5fc72f:#ebf300:#0777bc:#af5fb2:#1ee3e3:#b2b2b2:#686868:#dd5454:#5fc72f:#ebf300:#0777bc:#af5fb2:#34e2e2:#eeeeec"
    word_chars = "-,./?%&#:_~"
    custom_command = /bin/bash
[layouts]
  [[default]]
    [[[child1]]]
      parent = window0
      profile = default
      type = Terminal
    [[[window0]]]
      parent = ""
      type = Window
[plugins]

dmaphy commented 5 years ago

Thanks for this feedback David, I'm curious if the 1.92-2 build could work for you with Wayland as someone gave positive feedback exactly on the middle clicking topic here: FEDORA-2020-bd14a158cd.

Otherwise we'll have to backport the patch from upstream which could probably fix the issue, just for completeness the links:

https://github.com/gnome-terminator/terminator/issues/24 https://github.com/gnome-terminator/terminator/pull/51

davidcraven commented 5 years ago

Just tested it. Both problems persist in the referenced 1.92-2.fc31.

I also just noticed that when I split my screen horizontally, Ctrl+Shift+z (my custom split_vert keybinding) seems to "show"/"hide" the non-active split, and it is also set to scaled_zoom in the keybindings interface (but in both 1.92-1.fc31, where the keybinding still worked, as well as 1.92-2.fc31, where it does not).

So my guess would be that this option's default was changed (or the option was invented?) after I configured my keybinding, and either there was no check if the (new) default keybinding was already set to something else or a bogus check was made.

davidcraven commented 5 years ago

Just confirmed, deleting the scaled_zoom keybinding or setting it to another combination re-enables it for split_vert.

Sorry, should have added this to my last comment.

mattrose commented 5 years ago

Thanks for tracking this down. I think we have the middle-click paste problem fixed in master (see https://github.com/gnome-terminator/terminator/pull/51) for details, and, i'll take a look at new keybindings clobbering older customized ones. Given the way the code is, I think fixing this would require some refactoring, but it would aid us greatly if you could open an issue upstream https://github.com/gnome-terminator/terminator/issues

Please login to add feedback.

Metadata

Type

bugfix

Severity

medium

Karma

Signed

Content Type

RPM

Test Gating

ignored

Autopush Settings

Unstable by Karma

-3

Stable by Karma

Stable by Time

7 days

Dates

submitted

5 years ago

in testing

5 years ago

in stable

5 years ago

Builds

terminator-1.92-1.fc31

Automated Test Results

ignored

Test Cases


0	1	Test Case terminator split