Update of fprintd and libfprint. There are two main tests:

  • Check that enroll still works (and requires a password)
  • Check that no other USB devices become unusable (e.g. mouse suddenly lags until clicked)

Important changes:

  • Require authentication for enroll (i.e. password)
  • Fix race conditions in pam_fprintd
  • More udev autosupsend rules
  • Plenty of bugfixes
  • New supported hardware

How to install

sudo dnf upgrade --advisory=FEDORA-2020-f997de7d0e

This update has been submitted for testing by benzea.

9 months ago

This update's test gating status has been changed to 'failed'.

9 months ago

This update's test gating status has been changed to 'waiting'.

9 months ago

This update's test gating status has been changed to 'failed'.

9 months ago

This update has been pushed to testing.

9 months ago

Outch, looks like we have a regression in the dbus rules: https://gitlab.freedesktop.org/libfprint/fprintd/-/issues/92

This update has been unpushed.

benzea edited this update.

New build(s):

  • fprintd-1.90.6-1.fc33

Removed build(s):

  • fprintd-1.90.5-1.fc33

Karma has been reset.

9 months ago

This update has been submitted for testing by benzea.

9 months ago

This update has been pushed to testing.

9 months ago

This update's test gating status has been changed to 'passed'.

9 months ago

This update has been unpushed.

User Icon bitlord commented & provided feedback 9 months ago
karma

I know this is unpushed now (or in process), to me this breaks my system, su/sudo segfaults, or other kinds of logins which load pam_fprintd.so.

It's segfaulting in libc ( ...__strlen_avx2... ), but I was able to use gdb to get some info and pinpoint it to pam_fprintd.so and this update. To revert this I booted with rd.break remounted /sysroot (if I remember correctly, that's where rootfs is mounted) as rw and moved /lib64/security/pam_fprintd.so

The fix is already committed upstream.

The easiest workaround will probably be to just mask the systemd fprintd service. It only happens on machines without a fingerprint reader.

I'll post an update tomorrow.

Ah, a good trick to work around it is to log in via SSH. Because then you are remote and pam_fprintd will disable itself early and the crash should not happen.

Thanks @benzea Also I have found a #1905667 too late I guess ;-)

User Icon thunderbirdtr commented & provided feedback 9 months ago
karma

It break sudo/su as well. I had to "delete" in rescue mode.

benzea edited this update.

New build(s):

  • fprintd-1.90.7-1.fc33
  • libfprint-1.90.6-1.fc33

Removed build(s):

  • fprintd-1.90.6-1.fc33
  • libfprint-1.90.5-1.fc33

Karma has been reset.

9 months ago

This update has been submitted for testing by benzea.

9 months ago

This update's test gating status has been changed to 'failed'.

9 months ago

OK, another update now. This should fix the problems.

Erf, this package clearly needs to be in critpath since it can break login and su :( Not being in critpath is why openQA didn't test it; it would have caught the bug immediately.

I'll add it to critpath in comps and whitelist it for openQA testing, since critpath generation from comps is still broken AFAIK :/

Sounds like a plan.

As it happens, the crash we ran into here was one of the few corner cases that was not covered in the automated tests (i.e. no fingerprint device available). :-/

The upstream tests have been improved a lot recently and now also include the buggy corner case that we hit here. Those tests are run during package build. I don't have the PAM tests duplicated in the gating currently though (anything testing libfprint interactions is more interesting there).

This update has been pushed to testing.

9 months ago

This update's test gating status has been changed to 'passed'.

9 months ago
User Icon geraldosimiao commented & provided feedback 9 months ago
karma

Tested on two VMs and it worked fine with the new builds.

This update's test gating status has been changed to 'ignored'.

9 months ago

This update's test gating status has been changed to 'passed'.

9 months ago

Tested now on my bare metal installation and it worked fine. Bare metal install on Acer Aspire V3-571 v: V2.11 CPU: Quad Core Intel Core i7-3632QM GPU: Intel 3rd Gen Core processor Graphics Controller Desktop: KDE Plasma 5.20.4 Kernel: 5.9.13-200.fc33.x86_64 fprintd-1.90.7-1.fc33 libfprint-1.90.6-1.fc33 sudo-1.9.2-1.fc33.x86_64 libsss_sudo-2.4.0-3.fc33.x86_64

benzea edited this update.

New build(s):

  • fprintd-1.90.8-1.fc33

Removed build(s):

  • fprintd-1.90.7-1.fc33

Karma has been reset.

9 months ago

This update has been submitted for testing by benzea.

9 months ago

This update's test gating status has been changed to 'failed'.

9 months ago

OK, restarted the process again for an fprintd update.

This is pretty minor in comparison to the other ones though. i.e. pam_fprintd would not allow fingerprint authentication when fprintd was just started. It would work if you tried again within 5 seconds (the timeout in which fprintd does an idle-shutdown).

This update has been pushed to testing.

9 months ago

This update's test gating status has been changed to 'passed'.

9 months ago
User Icon pwalter commented & provided feedback 9 months ago
karma

Works

User Icon cserpentis commented & provided feedback 9 months ago
karma

works for me

This update can be pushed to stable now if the maintainer wishes

9 months ago
User Icon kparal commented & provided feedback 9 months ago
karma

no issues now

This update has been submitted for stable by bodhi.

9 months ago

This update has been pushed to stable.

9 months ago

Please login to add feedback.

Metadata
Type
security
Severity
medium
Karma
3
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
3
Stable by Time
7 days
Dates
submitted
9 months ago
in testing
9 months ago
in stable
9 months ago
modified
9 months ago

Automated Test Results