Please consider limiting this update to Rawhide at this point in the release cycle for F35.
There is a breaking API change, mentioned in the release notes (https://github.com/google/benchmark/releases/tag/v1.6.0), in that State::thread_index and State::threads are now accessor methods instead of data members. This means all packages that use these members will need to patched.
In addition, please consider sending a heads-up to the devel mailing list about the change.
I noticed the problem because grpc failed to rebuild into the side tag for OpenSSL 3.0. Here is what the necessary patch looked like for grpc.
Please consider limiting this update to Rawhide at this point in the release cycle for F35.
I need this update for F35 too. F35 is not released yet, so it's okay.
There is a breaking API change, mentioned in the release notes (https://github.com/google/benchmark/releases/tag/v1.6.0), in that State::thread_index and State::threads are now accessor methods instead of data members. This means all packages that use these members will need to patched.
Typical Google. They did this without a soversion bump.
Typical Google. They did this without a soversion bump.
I noticed. It was careless of them, and easy for you to miss.
I checked cctz, geometry-hpp, python-pypet, seqan3, and snappy. Based on source grepping and fedpkg mockbuild --enablerepo=local), none of them uses the part of the API that was changed. That’s less fallout than I expected!
I have no objection to carrying on with the F35 update at this point. I appreciate your work on handling this the right way.
This update has been submitted for testing by xvitaly.
This update's test gating status has been changed to 'ignored'.
This update's test gating status has been changed to 'waiting'.
This update's test gating status has been changed to 'ignored'.
This update has been pushed to testing.
Please consider limiting this update to Rawhide at this point in the release cycle for F35.
There is a breaking API change, mentioned in the release notes (https://github.com/google/benchmark/releases/tag/v1.6.0), in that
State::thread_index
andState::threads
are now accessor methods instead of data members. This means all packages that use these members will need to patched.In addition, please consider sending a heads-up to the
devel
mailing list about the change.I noticed the problem because grpc failed to rebuild into the side tag for OpenSSL 3.0. Here is what the necessary patch looked like for grpc.
Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.
I need this update for F35 too. F35 is not released yet, so it's okay.
Typical Google. They did this without a soversion bump.
Done: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/WKBNIOA3V3NHQ6ISZPVUFUAVCBZSMVOM/
I noticed. It was careless of them, and easy for you to miss.
I checked
cctz
,geometry-hpp
,python-pypet
,seqan3
, andsnappy
. Based on source grepping andfedpkg mockbuild --enablerepo=local
), none of them uses the part of the API that was changed. That’s less fallout than I expected!I have no objection to carrying on with the F35 update at this point. I appreciate your work on handling this the right way.
This update can be pushed to stable now if the maintainer wishes
xvitaly edited this update.
New build(s):
Karma has been reset.
This update has been submitted for testing by xvitaly.
This update has been pushed to testing.
This update can be pushed to stable now if the maintainer wishes
This update has been submitted for stable by xvitaly.
This update has been pushed to stable.