obsolete
FEDORA-2021-7f71a6a3d1 created by sentry a year ago for Fedora 34

correct macro once again to allow for proper packaging


improve macro for using the zig binary

This update has been submitted for testing by sentry.

a year ago

This update's test gating status has been changed to 'ignored'.

a year ago

This update's test gating status has been changed to 'waiting'.

a year ago

This update has obsoleted zig-0.8.0-3.fc34, and has inherited its bugs and notes.

a year ago

This update's test gating status has been changed to 'ignored'.

a year ago

This update has been pushed to testing.

a year ago

Almost working, but a few unwanted newlines slipped in. Notably, the line break after DESTDIR makes it so that DESTDIR is not applied to a command in the next line.

% rpm -E '%zig_install'

    DESTDIR="/home/alebastr/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64"
    /usr/bin/zig \
        build \
        --verbose  \
        --cache-dir zig-cache \
        install \
        --prefix "/usr" \
        --prefix-lib-dir "/usr/lib64" \
        --prefix-exe-dir "/usr/bin" \
        --prefix-include-dir "/usr/include"

Overall, it's not a good practice to start macro with a newline; for example, xvfb-run %zig_test will not do what any experienced packager expects it to do.

Yeah that is known the problem was that the %zig_build macro starts with a newline putting DESTDIR on a new line problem is gonna get fixed on the next release

This update has been obsoleted by zig-0.8.0-5.fc34.

a year ago

Please login to add feedback.

Metadata
Type
enhancement
Karma
0
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
3
Stable by Time
7 days
Dates
submitted
a year ago
in testing
a year ago

Automated Test Results