Use recommends for a few more things


Refresh Fedora logos, use larger logo variants

This update has been submitted for testing by pwalter.

a year ago

This update's test gating status has been changed to 'ignored'.

a year ago

This update's test gating status has been changed to 'waiting'.

a year ago

This update has obsoleted gnome-control-center-40.0-3.fc34, and has inherited its bugs and notes.

a year ago

This update's test gating status has been changed to 'ignored'.

a year ago
User Icon catanzaro commented & provided feedback a year ago
karma

Hi, the problem here is that power-profiles-daemon has not received enough testing yet because it wasn't installed by default before this update. The Recommends is going to result in it being installed by default. IMO it should only be added to F35, not to F34.

This update has been pushed to testing.

a year ago

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

a year ago
User Icon hadess commented & provided feedback a year ago
karma

This new daemon has been thoroughly tested downstream by Fedora developers, Fedora hardware partners. Given its architecture, it's a safe addition, and was given the go-ahead to be installed and enabled by default 6 months ago: https://pagure.io/fedora-workstation/issue/191

I don't think that its addition breaks the freeze, or requires an exception. If not accepted in stable before the hard freeze for release, this update could very well be scheduled for a zero-day release without breaking the update criteria.

Bastien, when we approved the change, we did not assume that implementation would be delayed until one week before final freeze. Adding a new system daemon one week before final freeze is not OK. However much testing you've done, it's no substitute for releasing the daemon as part of F34 beta and waiting to see how many bug reports we get. Maybe it would have gone perfectly fine, maybe not, but at this point it's just too late.

Please do not attempt to add a new system daemon in a post-release update: that's not allowed and we'll just require you to revert the update if you do. Wait until Fedora 35.

(I also recommend adding the daemon to F35 comps, so that this Recommends isn't the only thing that causes it to get pulled in.)

User Icon smithp commented & provided feedback a year ago
karma

+1

This update can be pushed to stable now if the maintainer wishes

a year ago

@catanzaro, please don't file negative karma because you don't want a feature in Fedora. Bodhi feedback is for regression testing only. Did this update break anything for you?

Can you two please stop changing other people's packages? I see you have commited another change now. File PRs please.

@pwalter No, it didn't break anything, but to be clear, you must not push this update because it will cause a new system daemon to be added to the default install. Negative karma is useful to indicate that the update should not be pushed. I'm already preparing a new update to obsolete this one.

As far as I can tell, you may have reintroduced this Recommends by mistake? Bastien removed it yesterday after I talked with him about it, then your commit added it back. We have some discussion in https://pagure.io/fedora-workstation/issue/191. Anyway, no further action is required, right now we're just waiting for koji.

This update has been unpushed.

WTF. We are just discussing it here and then you go and unpush my update just like that? And have the nerve to say "no further action is required".

If you undo your unpush and undo your negative karma then no further action is required from you. Thanks.

And no, I don't really care if the new daemon is installed by default or not. It is you coming here and overriding other people, especially after wg has decided to allow this. This is just blatant abuse of provenpackager access.

Hi Pete, I'm not a provenpackager. I can only touch gnome-control-center via gnome-sig. Honestly I'm quite surprised by your negative reaction here, because gnome-sig members push to our packages, including gnome-control-center, all the time. If you don't mind, perhaps you could join #fedora-desktop on irc.gnome.org so we can talk and perhaps coordinate better in the future. We discussed this power-profiles-daemon change there yesterday, and were surprised to see you reintroduce it today.

The WG approved power-profiles-daemon on the assumption that it would be installed by default and receive testing throughout the F34 development cycle. It's unfortunate that we didn't notice power-profiles-daemon was missing prior to now, but the week before final freeze is not the time to try to change that. If this update went out now, it would just inconvenience everybody, because we would have to apply for a freeze exception to undo it.

If it's not clear it is your attitude that is the problem here. You just don't come and revert a change a maintainer has done.

If you had asked nicely, 'Hey Pete or hey Bastian is it ok if we postpone it to F35' we would have been completely fine. Instead, you just come in and revert people's changes without allowing any discussion.

Sorry but this is not how Fedora works.

This update has been submitted for testing by pwalter.

a year ago

pwalter edited this update.

a year ago

This update has been submitted for stable by pwalter.

a year ago

I put my conclusion in the wg ticket. No further action is required from you right now, catanzaro (and please file PRs instead of messing up the package git history next time so we can have a discussion). Thanks

hadess and others who know how to behave when commit are fine to commit directly.

If you push this to stable, I will request your commit access to gnome-control-center be revoked.

If you mess with my update once more I am going to bring this to FESCo. This is a Fedora Workstation approved change and must land before the final freeze. Stop messing around. This is being discussed in https://pagure.io/fedora-workstation/issue/191

This update has been submitted for testing by pwalter.

a year ago

This update has been pushed to testing.

a year ago

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

a year ago

This update has been obsoleted by gnome-control-center-40.0-9.fc34.

a year ago

Please login to add feedback.

Metadata
Type
unspecified
Karma
1
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
disabled
Stable by Time
disabled
Dates
submitted
a year ago
in testing
a year ago
modified
a year ago

Automated Test Results