FEDORA-2021-f0e003a376 created by fjanus a week ago for Fedora 35
unpushed

improve previous patch to cover more cases


This release prevents high CPU usage in some cases

This update has been submitted for testing by fjanus.

a week ago

This update's test gating status has been changed to 'failed'.

a week ago

This update's test gating status has been changed to 'waiting'.

a week ago

This update has obsoleted libdb-5.3.28-48.fc35, and has inherited its bugs and notes.

a week ago

This update's test gating status has been changed to 'failed'.

a week ago

This update has been pushed to testing.

a week ago
User Icon besser82 commented & provided feedback 5 days ago
karma

Works great! LGTM! =)

This appears to break FreeIPA domain controller deployment with an error in directory server configuration:

https://openqa.fedoraproject.org/tests/981132#step/role_deploy_domain_controller/31

@ab

User Icon adamwill provided feedback 5 days ago
karma

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

5 days ago
User Icon ellert commented & provided feedback 5 days ago
karma

This update breaks the build of nordugrid-arc on ppc64le, due to failing tests.

The descrition for this update is "improve previous patch to cover more cases".

The previouss patch was:

diff -ur db-5.3.28/src/os/os_map.c db-patched/src/os/os_map.c
--- db-5.3.28/src/os/os_map.c   2013-09-09 17:35:09.000000000 +0200
+++ db-patched/src/os/os_map.c  2021-09-06 14:32:28.792139908 +0200
@@ -213,6 +213,10 @@
    if (rp->max < rp->size)
        rp->max = rp->size;
    if (ret == 0 && F_ISSET(infop, REGION_CREATE)) {
+#ifdef HAVE_MLOCK
+       if (F_ISSET(env, ENV_LOCKDOWN))
+           rp->size = rp->max;
+#endif
        if (F_ISSET(dbenv, DB_ENV_REGION_INIT))
            ret = __db_file_write(env, infop->fhp,
                rp->size / MEGABYTE, rp->size % MEGABYTE, 0x00);

The new patch is (after cleaning up unintentional indentation mistakes that makes it longer than necessary):

diff -ur db-5.3.28/src/os/os_map.c db_patch/src/os/os_map.c
--- db-5.3.28/src/os/os_map.c   2013-09-09 17:35:09.000000000 +0200
+++ db_patch/src/os/os_map.c    2021-09-09 07:33:12.027328265 +0200
@@ -213,6 +213,9 @@
    if (rp->max < rp->size)
        rp->max = rp->size;
    if (ret == 0 && F_ISSET(infop, REGION_CREATE)) {
+
+       rp->max = rp->size;
+
        if (F_ISSET(dbenv, DB_ENV_REGION_INIT))
            ret = __db_file_write(env, infop->fhp,
                rp->size / MEGABYTE, rp->size % MEGABYTE, 0x00);

This removes the condition, which is consistent with "to cover more cases". However, it also swaps the assignment from rp->size = rp->max; to rp->max = rp->size;, which was probably unintentional.

Was the patch intended to be:

diff -ur db-5.3.28/src/os/os_map.c db_patch/src/os/os_map.c
--- db-5.3.28/src/os/os_map.c   2013-09-09 17:35:09.000000000 +0200
+++ db_patch/src/os/os_map.c    2021-09-09 07:33:12.027328265 +0200
@@ -213,6 +213,9 @@
    if (rp->max < rp->size)
        rp->max = rp->size;
    if (ret == 0 && F_ISSET(infop, REGION_CREATE)) {
+
+       rp->size = rp->max;
+
        if (F_ISSET(dbenv, DB_ENV_REGION_INIT))
            ret = __db_file_write(env, infop->fhp,
                rp->size / MEGABYTE, rp->size % MEGABYTE, 0x00);
User Icon frenaud commented & provided feedback 4 days ago
karma

The update breaks ipa server installation

This update has been unpushed.


Please login to add feedback.

Metadata
Type
unspecified
Karma
-2
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
disabled
Stable by Time
disabled
Dates
submitted
a week ago
in testing
a week ago

Automated Test Results