FEDORA-2024-085cfeb1db — unspecified update for grub2

unpushed

grub2-2.12-9.fc40

FEDORA-2024-085cfeb1db created by nfrayer a year ago for Fedora 40

Changelog

* Thu Nov 21 2024 Peter Jones <pjones@redhat.com> - 2.12-9
- Rebuild to see if the builder is fixed
* Wed Sep 25 2024 Nicolas Frayer <nfrayer@redhat.com> 2.12-8
- NX: efi/loader, add a call to grub_efi_check_nx_required()
* Tue Sep 17 2024 Nicolas Frayer <nfrayer@redhat.com> - 2.12-7
- aarch64/macros: Build gnulib with -mbranch-protection=standard
* Thu Sep 5 2024 Leo Sandoval <lsandova@redhat.com> - 2.12-6
- load EFI commands inside test expressions
- Resolves: #2305291
* Thu Aug 29 2024 Leo Sandoval <lsandova@redhat.com> - 2.12-5
- Fix netbooting regressions introduced at 2.12-1
- Resolves: #2303727
* Thu Aug 08 2024 Peter Robinson <pbrobinson@fedoraproject.org> 2.12-4
- Build using fuse3
* Tue Aug 6 2024 Leo Sandoval <lsandova@redhat.com> - 2.12-3
- Remove 'efi: Use shim's loader protocol for EFI image verification'
* Tue Aug 6 2024 Nicolas Frayer <nfrayer@redhat.com> - 2.12-2
- mkconfig: More hardening to prevent overwriting grub cfg stub
* Mon Aug 5 2024 Leo Sandoval <lsandova@redhat.com> - 2.12-1
- Rebased to release grub2-2.12
* Fri Aug 2 2024 Leo Sandoval <lsandova@redhat.com> - 2.06-127
- Set /boot/grub2/grub.cfg to 0600 mode if present
* Mon Jul 22 2024 Leo Sandoval <lsandova@redhat.com> - 2.06.126
- grub.cfg: Fix rpm grub.cfg verification issues
* Tue Jul 16 2024 Nicolas Frayer <nfrayer@redhat.com> - 2.06-125
- grub2-mkconfig: Prevent mkconfig from overwriting grub cfg stub
* Tue Jul 2 2024 Nicolas Frayer <nfrayer@redhat.com> - 2.06-124
- KVM/PowerVM: Add support for KVM on PowerVM
- Resolved: #2294883

This update has been submitted for testing by nfrayer.

a year ago

This update's test gating status has been changed to 'waiting'.

a year ago

This update's test gating status has been changed to 'waiting'.

a year ago

nixuser commented & provided feedback a year ago

karma

Working OK, system still boots and nothing seems broken.

This update's test gating status has been changed to 'failed'.

a year ago

This update has been pushed to testing.

a year ago

boycottsystemd1 provided feedback a year ago

karma

boycottsystemd1 commented a year ago

ok on baremetal, legacy BIOS

This update's test gating status has been changed to 'waiting'.

a year ago

This update's test gating status has been changed to 'failed'.

a year ago

derekenz commented & provided feedback a year ago

karma

Works

adamwill commented & provided feedback a year ago

karma

Looks like there's a scriptlet in grub2-common which is broken during initial OS deployment. This is in the log from the failing openQA install test:

08:35:42,946 WARNING org.fedoraproject.Anaconda.Modules.Payloads:INFO:anaconda.modules.payloads.payload.dnf.transaction_progress:Configuring (running scriptlet for): grub2-common-1:2.12-9.fc40.noarch 1733159678 eedc517d02e256c5ec55669389ddac7468254532517c9672032a067e861a2b12
08:35:44,528 INFO kernel:SGI XFS with ACLs, security attributes, realtime, scrub, quota, no debug enabled
08:35:44,593 INFO kernel:JFS: nTxBlock = 8192, nTxLock = 65536
08:35:44,825 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/05efi on mounted /dev/vda1
08:35:44,830 NOTICE root:05efi: debug: /dev/vda1 is a FAT32 partition
08:35:44,867 NOTICE root:05efi: debug: /dev/vda1 partition scheme is gpt
08:35:44,867 NOTICE root:05efi: debug: /dev/vda1 partition type is c12a7328-f81f-11d2-ba4b-00a0c93ec93b
08:35:44,871 NOTICE root:05efi: debug: running subtest /usr/libexec/os-probes/mounted/efi/05shell
08:35:44,871 NOTICE root:05efi: debug: running subtest /usr/libexec/os-probes/mounted/efi/10elilo
08:35:44,880 NOTICE root:05efi: debug: running subtest /usr/libexec/os-probes/mounted/efi/20microsoft
08:35:44,889 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/10freedos on mounted /dev/vda1
08:35:44,893 NOTICE root:10freedos: debug: /dev/vda1 is a FAT32 partition
08:35:44,896 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/10qnx on mounted /dev/vda1
08:35:44,901 NOTICE root:10qnx: debug: /dev/vda1 is not a QNX4 partition: exiting
08:35:44,901 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/20macosx on mounted /dev/vda1
08:35:44,907 NOTICE macosx-prober:debug: /dev/vda1 is not an HFS+ partition: exiting
08:35:44,908 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/20microsoft on mounted /dev/vda1
08:35:44,912 NOTICE root:20microsoft: debug: Skipping legacy bootloaders on UEFI system
08:35:44,912 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/30utility on mounted /dev/vda1
08:35:44,916 NOTICE root:30utility: debug: /dev/vda1 is a FAT32 partition
08:35:44,922 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/40lsb on mounted /dev/vda1
08:35:44,927 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/70hurd on mounted /dev/vda1
08:35:44,931 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/80minix on mounted /dev/vda1
08:35:44,935 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/83haiku on mounted /dev/vda1
08:35:44,940 NOTICE root:83haiku: debug: /dev/vda1 is not a BeFS partition: exiting
08:35:44,941 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/90linux-distro on mounted /dev/vda1
08:35:44,952 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/90solaris on mounted /dev/vda1
08:35:44,959 NOTICE rsyslogd:imjournal: journal files changed, reloading...  [v8.2312.0-1.fc40 try https://www.rsyslog.com/e/0 ]
08:35:44,980 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/05efi on mounted /dev/vda2
08:35:44,981 NOTICE root:05efi: debug: /dev/vda2 is ext4 partition: exiting
08:35:44,982 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/10freedos on mounted /dev/vda2
08:35:44,985 NOTICE root:10freedos: debug: /dev/vda2 is not a FAT partition: exiting
08:35:44,985 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/10qnx on mounted /dev/vda2
08:35:44,990 NOTICE root:10qnx: debug: /dev/vda2 is not a QNX4 partition: exiting
08:35:44,990 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/20macosx on mounted /dev/vda2
08:35:44,995 NOTICE macosx-prober:debug: /dev/vda2 is not an HFS+ partition: exiting
08:35:44,996 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/20microsoft on mounted /dev/vda2
08:35:44,998 NOTICE root:20microsoft: debug: Skipping legacy bootloaders on UEFI system
08:35:44,999 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/30utility on mounted /dev/vda2
08:35:45,002 NOTICE root:30utility: debug: /dev/vda2 is not a FAT partition: exiting
08:35:45,002 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/40lsb on mounted /dev/vda2
08:35:45,005 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/70hurd on mounted /dev/vda2
08:35:45,009 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/80minix on mounted /dev/vda2
08:35:45,012 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/83haiku on mounted /dev/vda2
08:35:45,015 NOTICE root:83haiku: debug: /dev/vda2 is not a BeFS partition: exiting
08:35:45,015 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/90linux-distro on mounted /dev/vda2
08:35:45,021 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/mounted/90solaris on mounted /dev/vda2
08:35:45,037 NOTICE root:os-prober: debug: btrfs volume uuid=944f415c-0540-44f2-81fc-bce47ce7fe46 partition=/dev/vda3
08:35:45,037 NOTICE root:os-prober: debug: running /usr/libexec/os-probes/50mounted-tests on btrfs /dev/vda3
08:35:45,044 NOTICE root:50mounted-tests: debug: begin btrfs processing for 944f415c-0540-44f2-81fc-bce47ce7fe46
08:35:45,056 NOTICE root:50mounted-tests: debug: btrfs volume 944f415c-0540-44f2-81fc-bce47ce7fe46 mounted
08:35:45,098 INFO systemd:mnt-sysroot-var-lib-os\x2dprober-mount.mount: Deactivated successfully.
08:35:45,102 INFO systemd:mnt-sysimage-var-lib-os\x2dprober-mount.mount: Deactivated successfully.
08:35:45,109 NOTICE root:50mounted-tests: debug: running subtest /usr/libexec/os-probes/mounted/90linux-distro
08:35:45,116 NOTICE root:50mounted-tests: debug: begin btrfs processing for 944f415c-0540-44f2-81fc-bce47ce7fe46 subvol=home
08:35:45,125 NOTICE root:50mounted-tests: debug: running subtest /usr/libexec/os-probes/mounted/90linux-distro
08:35:45,132 NOTICE root:50mounted-tests: debug: begin btrfs processing for 944f415c-0540-44f2-81fc-bce47ce7fe46 subvol=root
08:35:45,141 NOTICE root:50mounted-tests: debug: begin btrfs processing for 944f415c-0540-44f2-81fc-bce47ce7fe46 subvol=root/var/lib/portables
08:35:45,158 NOTICE root:50mounted-tests: debug: running subtest /usr/libexec/os-probes/mounted/90linux-distro
08:35:45,169 INFO systemd:mnt-sysroot-var-lib-os\x2dprober-mount.mount: Deactivated successfully.
08:35:45,169 INFO systemd:mnt-sysimage-var-lib-os\x2dprober-mount.mount: Deactivated successfully.
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:INFO:dnf.rpm:Generating grub configuration file ...
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:Adding boot menu entry for UEFI Firmware Settings ...
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:done
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:grep: /boot/efi/EFI/fedora/grub.cfg: No such file or directory
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:grep: /boot/efi/EFI/fedora/grub.cfg: No such file or directory
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:cp: cannot stat '/boot/efi/EFI/fedora/grub.cfg': No such file or directory
08:35:45,245 WARNING org.fedoraproject.Anaconda.Modules.Payloads:warning: %posttrans(grub2-common-1:2.12-9.fc40.noarch) scriptlet failed, exit status 1
08:35:45,246 WARNING org.fedoraproject.Anaconda.Modules.Payloads:ERROR:dnf.rpm:Error in POSTTRANS scriptlet in rpm package grub2-common
08:35:45,247 WARNING org.fedoraproject.Anaconda.Modules.Payloads:ERROR:anaconda.modules.payloads.payload.dnf.transaction_progress:Error in POSTTRANS scriptlet in rpm package grub2-common

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

a year ago

adamwill commented a year ago

also, is it really a good idea to update a stable release from 2.06 to 2.12? does this not need an exception under the update policy?

adamwill commented a year ago

Doing a git diff f40 from the rawhide branch of the package repo, there are some significant differences in the posttrans script:

@@ -368,8 +402,10 @@ else
     fi
 fi

-if ((grep -q "configfile" ${EFI_HOME}/grub.cfg || grep -q "source" ${EFI_HOME}/grub.cfg) && ! grep -q "# It is automatically generated by grub2-mkconfig using templates" ${EFI_HOME}/grub.c
fg); then
-    exit 0 #Already unified
+if test -f ${EFI_HOME}/grub.cfg; then
+    if (((grep -q "configfile" ${EFI_HOME}/grub.cfg && grep -q "root-dev-only" ${EFI_HOME}/grub.cfg) || grep -q "source" ${EFI_HOME}/grub.cfg) && ! grep -q "# It is automatically generated
 by grub2-mkconfig using templates" ${EFI_HOME}/grub.cfg); then
+        exit 0 #Already unified
+    fi
 fi

 # create a stub grub2 config in EFI
@@ -388,8 +424,6 @@ if test -f ${EFI_HOME}/grubenv; then
     mv --force ${EFI_HOME}/grubenv ${GRUB_HOME}/grubenv
 fi

-cp -a ${EFI_HOME}/grub.cfg ${EFI_HOME}/grub.cfg.rpmsave
-cp -a ${EFI_HOME}/grub.cfg ${GRUB_HOME}/
 mv ${EFI_HOME}/grub.cfg.stb ${EFI_HOME}/grub.cfg

 %files common -f grub.lang

filiperosset commented & provided feedback a year ago

karma

no regressions noted

nfrayer commented a year ago

We have a fix for the posttrans issue but we're going to discuss about the 2.12 rebase as per the update policy, so let's not push this update ...

geraldosimiao commented & provided feedback a year ago

karma

as for adam pointed

sbonazzo commented & provided feedback a year ago

karma

Works for me

nfrayer provided feedback a year ago

nfrayer commented a year ago

This update has been unpushed.

Please log in to add feedback.

Metadata

Type

unspecified

Karma

Signed

Content Type

RPM

Test Gating

failed

Autopush Settings

Unstable by Karma

-3

Stable by Karma

disabled

Stable by Time

disabled

Thresholds

Minimum Karma

Minimum Testing

14 days

Dates

submitted

a year ago

in testing

a year ago

Builds

grub2-2.12-9.fc40

Automated Test Results

For help debugging failed Fedora CI tests (fedora-ci.*), contact the Fedora CI team.
For help debugging failed Fedora CoreOS tests (coreos.*), contact the Fedora CoreOS team.
For help debugging failed openQA tests (update.*), contact the Fedora Quality team, who will usually investigate and diagnose all failures within 24 hours.

failed