This update breaks the compiler setup for ROCm. We knew that llvm18 was going to be a problem and the plan was to move over to the llvm17 packages but it turns out that there are issues with the compiler-rt17 package which is needed for ROCm to build.
We don't have a rhbz for this issue yet but the llvm folks are aware of the problem and, as far as I know, are working on a fix.
@tstellar this is the issue we are working together on, the resource dir of clang17 needed adjusting to find where compiler-rt17 is install. this looks like it resolved building rocm bits wise with the pr you shared with me. i still need to run some tests and unfortunately rocblas takes forever to build
rocblas-test has been running for a while, I am not really sure it it hours or days before it completes, the scroll back output looks fine. I say tom's change is good and we move forward.
We discussed the systemd failure in #2269010 and the consensus is to ignore it for now. Apart from systemd (which we compile with gcc normally), I don't see other issues.
BZ#2266081 Consider LLVM 18 pull in during Beta Freeze
Rebuilding ROCm on rawhide is taking a while without testing.
There is no time to do both the build and testing on F40 before the feeze.
So llvm 18 on F40 will outright break the ROCm 6.0 feature and put the PyTorch feature at risk.
llvm should never be upgraded this late.
We were not anticipating that the ROCm packages would need to be rebuilt. When we discussed this issue back in December with the ROCm maintainers, I thought the conclusion was that ROCm would continue using llvm 17 via the compat packages and this would reduce the need for doing rebuilds. We added virtual provides to the compat packages specifically to support ROCm in this way, and we also added a completely new compat package (compiler-rt17) for this.
@trix Both LLVM and rocm are accepted changes for Fedora 40, and are equally important. rocm can stay on the previous llvm release even with LLVM 18 arriving (and can continue to be built against llvm 17 if needed).
This update's test gating status has been changed to 'waiting'.
This update's test gating status has been changed to 'waiting'.
This update has been submitted for testing by bodhi.
This update's test gating status has been changed to 'failed'.
The compiler-rt test failure looks like a bug in the test.
frantisekz edited this update.
This update has been pushed to testing.
The new compat packages (e.g. clang17) requires an update to https://github.com/rpminspect/rpminspect-data-fedora/pull/46/files.
I am using a system with this update and I have not seen any problems so far.
This update's test gating status has been changed to 'waiting'.
This update's test gating status has been changed to 'passed'.
This update can be pushed to stable now if the maintainer wishes
This update has been submitted for stable by frantisekz.
There is an ongoing freeze; this will be pushed to stable after the freeze is over.
frantisekz edited this update.
New build(s):
Karma has been reset.
This update has been submitted for testing by frantisekz.
This update's test gating status has been changed to 'waiting'.
This update's test gating status has been changed to 'passed'.
This update breaks the compiler setup for ROCm. We knew that llvm18 was going to be a problem and the plan was to move over to the llvm17 packages but it turns out that there are issues with the compiler-rt17 package which is needed for ROCm to build.
We don't have a rhbz for this issue yet but the llvm folks are aware of the problem and, as far as I know, are working on a fix.
@tflink Can you file a bug so we are all on the same page?
This update has been pushed to testing.
Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.
@tstellar this is the issue we are working together on, the resource dir of clang17 needed adjusting to find where compiler-rt17 is install. this looks like it resolved building rocm bits wise with the pr you shared with me. i still need to run some tests and unfortunately rocblas takes forever to build
I'll hold the stable push for this until the above issue is resolved.
rocblas-test has been running for a while, I am not really sure it it hours or days before it completes, the scroll back output looks fine. I say tom's change is good and we move forward.
tstellar edited this update.
New build(s):
Removed build(s):
Karma has been reset.
This update has been submitted for testing by tstellar.
clang17-17.0.6-7.fc40 should fix the ROCm issue.
This update has been pushed to testing.
This update can be pushed to stable now if the maintainer wishes
Hmm, clang-18 seems to miscompile systemd code. I'll file a bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2269010
We discussed the systemd failure in #2269010 and the consensus is to ignore it for now. Apart from systemd (which we compile with gcc normally), I don't see other issues.
Rebuilding ROCm on rawhide is taking a while without testing. There is no time to do both the build and testing on F40 before the feeze. So llvm 18 on F40 will outright break the ROCm 6.0 feature and put the PyTorch feature at risk. llvm should never be upgraded this late.
We were not anticipating that the ROCm packages would need to be rebuilt. When we discussed this issue back in December with the ROCm maintainers, I thought the conclusion was that ROCm would continue using llvm 17 via the compat packages and this would reduce the need for doing rebuilds. We added virtual provides to the compat packages specifically to support ROCm in this way, and we also added a completely new compat package (compiler-rt17) for this.
If there are specific issues with the packages that are making it necessary to do rebuilds, please file bugs for these.
@trix Both LLVM and rocm are accepted changes for Fedora 40, and are equally important. rocm can stay on the previous llvm release even with LLVM 18 arriving (and can continue to be built against llvm 17 if needed).
I've rebuilt mupdf into the side-tag successfully.
This update has been submitted for stable by adamwill.
There is an ongoing freeze; this will be pushed to stable after the freeze is over.
This update has been pushed to stable.