unpushed

libtirpc-1.3.6-0.rc1.fc41

FEDORA-2024-eb19549211 created by steved a year ago for Fedora 41

Updated to the latest upstream RC release: libtirpc-1-3-7-rc1

This update has been submitted for testing by steved.

a year ago

This update's test gating status has been changed to 'waiting'.

a year ago

This update's test gating status has been changed to 'waiting'.

a year ago
User Icon cmorris commented & provided feedback a year ago
karma

The rpm version disagrees with the libtirpc version that is supposed to be in this update (1.3.6-0.rc1.fc41 versus libtirpc-1-3-7-rc1, respectively), and predates the rpm version that it is supposed to supersede, 1.3.6-0.fc41.

Bodhi is disabling automatic push to stable due to negative karma. The maintainer may push manually if they determine that the issue is not severe.

a year ago

This update's test gating status has been changed to 'failed'.

a year ago

This update has been pushed to testing.

a year ago
User Icon bojan commented & provided feedback a year ago
karma

It is also possibly functionally broken. See nfs-utils feedback.

This update's test gating status has been changed to 'waiting'.

a year ago
User Icon derekenz commented & provided feedback a year ago
karma

Works

This update's test gating status has been changed to 'failed'.

a year ago

The rpm version disagrees with the libtirpc version that is supposed to be in this update (1.3.6-0.rc1.fc41 versus libtirpc-1-3-7-rc1, respectively), and predates the rpm version that it is supposed to supersede, 1.3.6-0.fc41.

The latest upstream tag is libtirpc-1-3-7-rc1 and the latest version is 1.3.6-0.rc1... My apologies but I don't see the problem.

Your release package should probably have a release number starting at 1 and then going up. For example: 1.3.6-1. Your RC package should probably be something like: 1.3.7-0.rc1. Right?

User Icon adamwill commented & provided feedback a year ago
karma

The versioning of the previous build (libtirpc-1.3.6-0.fc41) is invalid under the guidelines, but there's no actual version ordering error here, 1.3.6-0.rc1.fc41 is greater than 1.3.6-0.fc41 so this update is higher versioned than the previous build. But in future please don't version packages with just a bare 0 as the release, @steved , it is not in line with the policy and it is unclear what it means. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ for the current versioning guidelines.

I also agree with @bojan that it seems unclear what this package contains. The description of the update says it contains "libtirpc-1-3-7-rc1" but the version is 1.3.6-0.rc1.fc41. Looking into what it actually contains, the sources file says:

[adamw@xps13a libtirpc (f41)]$ cat sources 
SHA512 (libtirpc-1.3.6.tar.bz2) = f3ccc45f9de8d517ccc10dd4b68b844bbe71a2cb61ca5819995d97319353f7e24cfee205e09dddf65cf47605314176aee161091d7379b6113ee8d1f5077c93d0

...that is, it actually appears to contain 1.3.6 final. However, it includes a single patch, which contains a commit with summary "getnetconfig.c: free linep to avoid memory leakage", and looking at http://git.linux-nfs.org/?p=steved/libtirpc.git;a=summary , we can see that commit is actually the only thing that changed between 1.3.6 final and 1.3.7 rc1.

So it looks like the previous build was actually 1.3.6 final (and so should have been versioned 1.3.6-1), and this build is in fact equivalent to 1.3.7 rc1, so should be versioned 1.3.7-0.1.rc1 (old-style) or 1.3.7~rc1-1 (new-style).

Anyhow, this update seems to have a bigger issue - it consistently causes rpc.mountd to crash when starting nfs-server.service. See https://bugzilla.redhat.com/show_bug.cgi?id=2325584 . Weirdly, this is not happening with the equivalent update for F40 or Rawhide, but it is consistently happening with this update (it's happened 7/7 times the test has run on this update, and never happened on any other F41 update over that time period).

This update has been unpushed.


Please log in to add feedback.

Metadata
Type
unspecified
Karma
-2
Signed
Content Type
RPM
Test Gating
Autopush Settings
Unstable by Karma
-3
Stable by Karma
disabled
Stable by Time
disabled
Thresholds
Minimum Karma
+2
Minimum Testing
14 days
Dates
submitted
a year ago
in testing
a year ago

Automated Test Results