It's not deploying the file: /usr/share/atop/atop.daily

and it should remove the file: /etc/logrotate.d/atop

The script atop.daily will be called by the systemd script (manually or by the daily cronjob) and will take care of cleaning the old log files.

There's been a lot of back and forth on log rotation over the years for atop. If this is the new "upstream blessed" method, I'll make the switch, otherwise, maybe I'll just ship both. Thoughts?

You're right :-) It seems the upstream method is good now. If you look at the atop.daily it also does a redirect of the current day log to atop.log.

Better to remove the logrotate one. Then we can do some testing.. :-)

-Marco Rodrigues

Please try this build. If it does what you expect I'll send this to EL-7 and rawhide.

It works fine, but the problem is the log rotation will not work as expected. It should start with the /usr/share/atop/atop.daily in the systemd.

So the unit file should be:

[Unit] Description=advanced interactive monitor After=syslog.target

[Service] Type=forking ExecStart=/usr/share/atop/atop.daily

[Install] WantedBy=multi-user.target

?

If you use the atop.service that comes in the tarball, it will have that yes.

https://github.com/Atoptool/atop/blob/master/atop.service

Ok, please try this build: https://fedorapeople.org/~limb/atop/atop-2.3.0-4.el7.centos.x86_64.rpm

It works as expected. Thanks.

Cool, I'll get this out.