FEDORA-EPEL-2017-f7b1be04d2 created by limb 2 years ago for Fedora EPEL 7
obsolete

2.3.0

This update has been submitted for testing by limb.

2 years ago
User Icon anonymous commented & provided feedback 2 years ago

It's not deploying the file: /usr/share/atop/atop.daily

and it should remove the file: /etc/logrotate.d/atop

The script atop.daily will be called by the systemd script (manually or by the daily cronjob) and will take care of cleaning the old log files.

BZ#1509943 Update to version 2.3.0
User Icon limb commented & provided feedback 2 years ago

There's been a lot of back and forth on log rotation over the years for atop. If this is the new "upstream blessed" method, I'll make the switch, otherwise, maybe I'll just ship both. Thoughts?

This update has been pushed to testing.

2 years ago
User Icon anonymous commented & provided feedback 2 years ago

You're right :-) It seems the upstream method is good now. If you look at the atop.daily it also does a redirect of the current day log to atop.log.

Better to remove the logrotate one. Then we can do some testing.. :-)

-Marco Rodrigues

User Icon limb commented & provided feedback 2 years ago

Please try this build. If it does what you expect I'll send this to EL-7 and rawhide.

User Icon gothicx commented & provided feedback 2 years ago

It works fine, but the problem is the log rotation will not work as expected. It should start with the /usr/share/atop/atop.daily in the systemd.

User Icon limb commented & provided feedback 2 years ago

So the unit file should be:

[Unit] Description=advanced interactive monitor After=syslog.target

[Service] Type=forking ExecStart=/usr/share/atop/atop.daily

[Install] WantedBy=multi-user.target

?

User Icon gothicx commented & provided feedback 2 years ago

If you use the atop.service that comes in the tarball, it will have that yes.

https://github.com/Atoptool/atop/blob/master/atop.service

User Icon gothicx commented & provided feedback 2 years ago

It works as expected. Thanks.

User Icon limb commented & provided feedback 2 years ago

Cool, I'll get this out.

This update has been obsoleted by atop-2.3.0-4.el7.

2 years ago

Please login to add feedback.

Metadata
Type
enhancement
Severity
low
Karma
0
Signed
Content Type
RPM
Test Gating
Settings
Unstable by Karma
-3
Stable by Karma
3
Stable by Time
disabled
Dates
submitted
2 years ago
in testing
2 years ago
BZ#1509943 Update to version 2.3.0
0
0

Automated Test Results